New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763826 link

Starred by 1 user
Status: Verified
Owner:
bsep@chromium.org
Closed: Sep 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : The 'First Run Bubble' appears smaller in size than expected.

Reported by avsha...@etouch.net, Sep 11 2017 
Chrome version : 63.0.3212.0 (Official Build) c3a3481c4b1b08775b477144d1d2873a2a3d9900-refs/heads/master@{#500792} 32/64 bit
OS : Windows(7,8,10)

What steps will reproduce the problem?
1. Install a fresh copy of Chrome browser and launch it.
2. Open NTP and observe the 'First Run Bubble'.

Actual Result : The 'First Run Bubble' appears smaller than expected.

Expected Result : 'First Run Bubble' should have proper sizing.

This is a regression issue broken in ‘M-63’ and will soon update remaining information.
First Run Bubble.png
26.9 KB View Download

Comment 1 by avsha...@etouch.net, Sep 11 2017

Labels: hasbisect-per-revision OS-Linux
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build : 63.0.3210.0 (Revision:500530).
Bad build : 63.0.3211.0 (Revision:500753).

You are probably looking for a change made after 500728 (known good), but no later than 500729 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/223d73be9b3c274be42a356b6cbc64def6c7a7c1..9f9851702f1fd544b8f15f522e511595d74f74c6

Suspect : https://chromium.googlesource.com/chromium/src/+/9f9851702f1fd544b8f15f522e511595d74f74c6

@bsep : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : Issue is also seen on Linux(14.04 LTS) OS but the same issue is not reproducible on Mac(10.11.6, 10.12.3, 10.12.5) OS.

Comment 2 by msrchandra@chromium.org, Sep 11 2017

Labels: ReleaseBlock-Stable
Adding RB Stable as this is a recent Regression.
Thank You.

Comment 3 by bsep@chromium.org, Sep 11 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126cc15506eb2d0bfd0865efd4ab0d20c995be3b

commit 126cc15506eb2d0bfd0865efd4ab0d20c995be3b
Author: Bret Sepulveda <bsep@chromium.org>
Date: Mon Sep 11 23:56:59 2017

Fix the padding around FirstRunBubble's content being too small.

I didn't realize the border set in FirstRunBubble was "extra" padding,
not the total padding, so I've reverted the change and moved the calls
around so the intent is clearer.

Bug:  763826 
Change-Id: Ieb0ab3d93bfb62f3738e970b9fac2c2a3e129332
Reviewed-on: https://chromium-review.googlesource.com/660684
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501103}
[modify] https://crrev.com/126cc15506eb2d0bfd0865efd4ab0d20c995be3b/chrome/browser/ui/views/first_run_bubble.cc

Comment 5 by avsha...@etouch.net, Sep 12 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3213.0
Update : 
Retested above issue in latest Chrome canary #63.0.3213.0 on Windows(7,8,10) OS and issue seems fixed. Now the First Run Bubble appears in proper size. Kindly review an attached screen cast.
(Note : Unable to verify this issue on Linux OS since the Linux canary #63.0.3213.0 has failed) 

Thank you!
Current_Result.mp4
640 KB View Download

Comment 6 by bsep@chromium.org, Sep 18 2017

Status: Verified (was: Started)
►

Sign in to add a comment