New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Slave request to investigate goma performance on windows buildbot

Project Member Reported by tikuta@chromium.org, Sep 11 2017

Issue description

We are seeing large performance difference of goma on engineer's strong machine and buildbot slaves.

To improve compile speed on buildbot, I will take profiling of goma on buildbots to find slow spot when running on buildbot vm.

Example slave: vm766-m4
- https://build.chromium.org/p/tryserver.chromium.win/buildslaves/vm766-m4
OS: Win
Version: 7
Bitness: 64
Waterfall: nothing
Details:
- to investigate goma performance on buildbot

 

Comment 1 by pschm...@google.com, Sep 11 2017

Cc: -d...@chromium.org
Owner: pschmidt@chromium.org
Status: Assigned (was: Untriaged)
Just deployed vm678-m4 for you.  Please let us know when you are done with it.

Thanks!

Comment 3 by tikuta@chromium.org, Sep 13 2017

Status: Fixed (was: Assigned)
Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/55ac9b6005b9af808187a64d4edddf91148fb803

commit 55ac9b6005b9af808187a64d4edddf91148fb803
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Thu May 17 14:22:49 2018

FROMLIST: vhost: add vsock compat ioctl

This will allow usage of vsock from 32-bit binaries on a 64-bit
kernel.

BUG= chromium:763790 
TEST=build caroline with USE=kvm_host

Change-Id: I51bcf5087dd079360fe81c3d443c981aac24d4b7
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
(am from https://patchwork.kernel.org/patch/10283631/)
Reviewed-on: https://chromium-review.googlesource.com/963512
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1058978
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/55ac9b6005b9af808187a64d4edddf91148fb803/drivers/vhost/vsock.c

Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d9c046a08d0ccdd927d5efffcbbf2ba66271c4b6

commit d9c046a08d0ccdd927d5efffcbbf2ba66271c4b6
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Thu May 17 14:22:50 2018

FROMLIST: vhost: fix vhost ioctl signature to build with clang

Clang is particularly anal about signed vs unsigned comparisons and
doesn't like the fact that some ioctl numbers set the MSB, so we get
this error when trying to build vhost on aarch64:

v4.4/drivers/vhost/vhost.c:793:7: error: overflow converting case value to
switch condition type (3221794578 to 18446744072636378898) [-Werror,-Wswitch]
        case VHOST_GET_VRING_BASE:

Fix this by using unsigned ints in the function signature for
vhost_vring_ioctl().

BUG= chromium:763790 
TEST=build caroline with USE=kvm_host

Change-Id: Id3e5bfe7aaa3a87926971aae230477ce73f7e5ed
(am from https://patchwork.kernel.org/patch/10283019/)
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/854775
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1058979
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/d9c046a08d0ccdd927d5efffcbbf2ba66271c4b6/drivers/vhost/vhost.c
[modify] https://crrev.com/d9c046a08d0ccdd927d5efffcbbf2ba66271c4b6/drivers/vhost/vhost.h

Sign in to add a comment