Issue metadata
Sign in to add a comment
|
Regression : Tool tip is seen Missing for profile pictures in 'Create Supervised User' overlay |
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3212.0/9930.0.0 dev-channel Daisy,Candy and Reks OS: Chrome What steps will reproduce the problem? (1)In sign-out screen click on three dot Menu to 'Add supervised User' (2)Click on 'Create Supervised User' -> Now enter password in'Choose the manager for this supervised user' Overlay -> Navigates to 'Create Supervised User' overlay (3)Now at Profile pictures hover mouse on them and observe for Tool tip (Please refer Video) Expected: Tool tip should be seen on Hovering mouse on Profile pictures Actual: Instead Tool tip is seen Missing This is Regression Issue as same is working fine in 63.0.3207.0/9922.0.0 dev channel candy
,
Sep 11 2017
,
Sep 11 2017
Thanks for the report. I'll investigate this asap. +hcarmona as this might be related to the accessibility improvements we made.
,
Sep 11 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/802456f677be6e34686a96c01e79f08e91c2fa5e commit 802456f677be6e34686a96c01e79f08e91c2fa5e Author: David Reveman <reveman@chromium.org> Date: Tue Sep 12 01:51:34 2017 oobe: Fix profile picture support when adding supervised user. This makes a minimal set up changes to get the supervised user creation screen to support the new set of default user images. The changes are: - Limit default images to 23 first images of current set. - Increase size of image grid to 272px to be able to display 23 images. - Always scale default image to 220x220px. - Use 576x576 capture size to match settings UI. - Disable animation for grid images. - Always use 2x resource for preview. Limiting the number of default images to 23 avoids more complicated changes needed to support proper overflow handling for the grid. This can be improved as part of more general UI updates to the supervised user creation flow. Bug: 763780 , 763777 , 763776 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64346ee6baa8dedb1b3acc8d738716c96f6aa0d7 Reviewed-on: https://chromium-review.googlesource.com/661862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501150} [modify] https://crrev.com/802456f677be6e34686a96c01e79f08e91c2fa5e/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css [modify] https://crrev.com/802456f677be6e34686a96c01e79f08e91c2fa5e/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js [modify] https://crrev.com/802456f677be6e34686a96c01e79f08e91c2fa5e/chrome/browser/resources/chromeos/user_images_grid.js
,
Sep 12 2017
,
Sep 12 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5dad61c441bcec2dc060bc854d3b0d5aab6285b commit c5dad61c441bcec2dc060bc854d3b0d5aab6285b Author: David Reveman <reveman@chromium.org> Date: Wed Sep 13 03:21:13 2017 oobe: Fix profile picture support when adding supervised user. This makes a minimal set up changes to get the supervised user creation screen to support the new set of default user images. The changes are: - Limit default images to 23 first images of current set. - Increase size of image grid to 272px to be able to display 23 images. - Always scale default image to 220x220px. - Use 576x576 capture size to match settings UI. - Disable animation for grid images. - Always use 2x resource for preview. Limiting the number of default images to 23 avoids more complicated changes needed to support proper overflow handling for the grid. This can be improved as part of more general UI updates to the supervised user creation flow. TBR=reveman@chromium.org (cherry picked from commit 802456f677be6e34686a96c01e79f08e91c2fa5e) Bug: 763780 , 763777 , 763776 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64346ee6baa8dedb1b3acc8d738716c96f6aa0d7 Reviewed-on: https://chromium-review.googlesource.com/661862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501150} Reviewed-on: https://chromium-review.googlesource.com/663306 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#194} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/c5dad61c441bcec2dc060bc854d3b0d5aab6285b/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css [modify] https://crrev.com/c5dad61c441bcec2dc060bc854d3b0d5aab6285b/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js [modify] https://crrev.com/c5dad61c441bcec2dc060bc854d3b0d5aab6285b/chrome/browser/resources/chromeos/user_images_grid.js
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe777a64902291225fe918761a2e4c17daf13419 commit fe777a64902291225fe918761a2e4c17daf13419 Author: David Reveman <reveman@chromium.org> Date: Wed Sep 13 21:28:30 2017 oobe: Fix profile picture support when adding supervised user. This makes a minimal set up changes to get the supervised user creation screen to support the new set of default user images. The changes are: - Limit default images to 23 first images of current set. - Increase size of image grid to 272px to be able to display 23 images. - Always scale default image to 220x220px. - Use 576x576 capture size to match settings UI. - Disable animation for grid images. - Always use 2x resource for preview. Limiting the number of default images to 23 avoids more complicated changes needed to support proper overflow handling for the grid. This can be improved as part of more general UI updates to the supervised user creation flow. TBR=reveman@chromium.org (cherry picked from commit 802456f677be6e34686a96c01e79f08e91c2fa5e) Bug: 763780 , 763777 , 763776 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64346ee6baa8dedb1b3acc8d738716c96f6aa0d7 Reviewed-on: https://chromium-review.googlesource.com/661862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501150} Reviewed-on: https://chromium-review.googlesource.com/665821 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1190} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/fe777a64902291225fe918761a2e4c17daf13419/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css [modify] https://crrev.com/fe777a64902291225fe918761a2e4c17daf13419/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js [modify] https://crrev.com/fe777a64902291225fe918761a2e4c17daf13419/chrome/browser/resources/chromeos/user_images_grid.js
,
Sep 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Sep 11 201716.5 MB
16.5 MB Download