New issue
Advanced search Search tips

Issue 763775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The size of the allowed jitter in EchoCanceller3 reduces the glitch recovery time

Project Member Reported by peah@chromium.org, Sep 11 2017

Issue description

The size of the allowed jitter in EchoCanceller3 reduces the glitch recovery time. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ea154106a81f2f8f08850a19caee09834283a673

commit ea154106a81f2f8f08850a19caee09834283a673
Author: peah <peah@webrtc.org>
Date: Mon Sep 11 13:44:37 2017

Lowered the allowed jitter in the api calls to a reasonable level

This CL reduces the allowed jitter in the api calls to a reasonable
level in order to ensure a quicker revery from audio path glitches.

BUG= webrtc:8224 ,  chromium:763775 

Review-Url: https://codereview.webrtc.org/3009273002
Cr-Commit-Position: refs/heads/master@{#19772}

[modify] https://crrev.com/ea154106a81f2f8f08850a19caee09834283a673/webrtc/modules/audio_processing/aec3/aec3_common.h

Comment 2 by peah@chromium.org, Sep 13 2017

Labels: Merge-Request-62
Can you please mark all impacted OS's?

Comment 4 by peah@chromium.org, Sep 13 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 14 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 15 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e99bccc07af913e7d4f90ca4d46dae148d3929e6

commit e99bccc07af913e7d4f90ca4d46dae148d3929e6
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Sep 15 19:09:40 2017

Merge of Lowered the allowed jitter in the api calls to a reasonable level

This CL reduces the allowed jitter in the api calls to a reasonable
level in order to ensure a quicker revery from audio path glitches.

BUG= webrtc:8224 ,  chromium:763775 
TBR=henrik.lundin@webrtc.org

(cherry picked from commit ea154106a81f2f8f08850a19caee09834283a673)

Review-Url: https://codereview.webrtc.org/3009273002
Cr-Original-Commit-Position: refs/heads/master@{#19772}
Change-Id: I5d446c159cdbdda26ba1485a7e4a711cf1fcef5c
Reviewed-on: https://webrtc-review.googlesource.com/1564
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/62@{#9}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}
[modify] https://crrev.com/e99bccc07af913e7d4f90ca4d46dae148d3929e6/webrtc/modules/audio_processing/aec3/aec3_common.h

Comment 8 by peah@chromium.org, Sep 15 2017

Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 18 2017

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62
Merged - removing label

Sign in to add a comment