The specific repro here is:

(2) Click on the 'Update sync passphrase' ('Sync Error') *Notification*

The bug is that opening the Settings UI from the notification does not focus the Settings window.

This is likely a symptom of another bug or behavior change. I will try to do a bisect to determine the cause.

There are actually two levels to this bug:


1. Clicking on the notification from the message center should focus Settings.
2. Clicking on the notification or 'Update sync passphrase' button when the notification "pops up" on login should focus Settings.

@ #499830 both succeed
@ #500311 #1 fails but #2 succeeds
@ #500792 both #1 and #2 fail

I am bisecting now (I suspect this is a symptom of a larger problem).

Bisect reveled the root cause:
https://chromium-review.googlesource.com/c/chromium/src/+/603547

That change has been merged to 3202 so we can't just easily revert it (and possibly do not want to, it may be better to fix the message center)

To summarize the bug:

1. Log into Chrome OS with an account with a separate sync passphrase. This will trigger a notification.
2. Click on the notification. The Settings UI will be shown.

Expected: The Settings UI should have keyboard focus.
Actual: The notification still has keyboard focus.

When this change was introduced, the bug only occurs after the message center is opened, not when the notification first appears.

I believe that @ c3a3481c4b1b08775b477144d1d2873a2a3d9900 (#500792) the bug also affects the initial notification, which is curious. I am confirming that now and will bisect the additional regression if that is indeed the case since it may be a separate issue.

I can't actually reproduce the failure from the initial pop up notification, and looking at the repro that's not actually the initial popup, so never mind that.

The repro is:
1. Log into Chrome OS with an account with a separate sync passphrase. This will trigger a sync notification after a second or two.
2. Click on the message center icon to show the sync notification in the message center.
3. Click on the sync notification. The Settings UI will be shown but the message center will still have keyboard focus.

Pasting here my recap from off-thread

There's two things here:

1. Notification + Notification center should indeed be closed and the notification dismissed.

2. The notification shouldn't show an action row with an "UPDATE THE PASSPHRASE" button as it is redundant. such action should be bound to the main touch target of the notification (content).

Pasting here my recap from off-thread

There's two things here:

1. Notification + Notification center should indeed be closed and the notification dismissed.

2. The notification shouldn't show an action row with an "UPDATE THE PASSPHRASE" button as it is redundant. such action should be bound to the main touch target of the notification (content).

+yoshiki@

FWIW, that is the behavior when the notification initially comes up (i.e. before it disappears into the message center), so I agree that this is a message center bug.

Also, the "Update sync passphrase" button only appears:
a) When the notification first appears
b) After the top row is clicked on (this appears to 'expand' the notification)

Thank you for confirming the expected behavior! Assign this to yoshiki@ as this seems to be a message center issue. Feel free to reassign this.

Just a reminder that this is an M63 beta blocker. M63 goes beta 10/26. 

This CL https://crrev.com/c/718056 fixed the problem on ToT so let's merge to M63.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.