Switching to conservative mode after timeout mode causes excessive ducking |
|||||||||
Issue descriptionThe switching to the conservative mode in echo canceller 3 is too fast and has in scenarios with an unbalanced conversation too large implications on the transparency.
,
Sep 13 2017
,
Sep 13 2017
Can you please mark all impacted OS's?
,
Sep 13 2017
,
Sep 14 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14 2017
Approving merge to M62. Branch:3202
,
Sep 15 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/a37a7099bf92fbe9366dee4abeec53b888785b20 commit a37a7099bf92fbe9366dee4abeec53b888785b20 Author: Per Åhgren <peah@webrtc.org> Date: Fri Sep 15 19:10:15 2017 Merge of Removed the timeout for the delay estimate quality. BUG= webrtc:8223 , chromium:763761 TBR=henrik.lundin@webrtc.org (cherry picked from commit c6b1041d6782ca3a483ac72f42c85375230a48c8) Review-Url: https://codereview.webrtc.org/3011193002 Cr-Original-Commit-Position: refs/heads/master@{#19773} Change-Id: I1009622020192e24e6dfb1306498db529d03933d Reviewed-on: https://webrtc-review.googlesource.com/1563 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/62@{#10} Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592} [modify] https://crrev.com/a37a7099bf92fbe9366dee4abeec53b888785b20/webrtc/modules/audio_processing/aec3/render_delay_controller.cc [modify] https://crrev.com/a37a7099bf92fbe9366dee4abeec53b888785b20/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc
,
Sep 15 2017
,
Sep 18 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 20 2017
Merged - removing label |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 11 2017