New issue
Advanced search Search tips

Issue 763761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Switching to conservative mode after timeout mode causes excessive ducking

Project Member Reported by peah@chromium.org, Sep 11 2017

Issue description

The switching to the conservative mode in echo canceller 3 is too fast and has in scenarios with an unbalanced conversation too large implications on the transparency.
 
 

Comment 2 by peah@chromium.org, Sep 13 2017

Labels: Merge-Request-62
Can you please mark all impacted OS's?

Comment 4 by peah@chromium.org, Sep 13 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 14 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 15 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a37a7099bf92fbe9366dee4abeec53b888785b20

commit a37a7099bf92fbe9366dee4abeec53b888785b20
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Sep 15 19:10:15 2017

Merge of Removed the timeout for the delay estimate quality.

BUG= webrtc:8223 ,  chromium:763761 

TBR=henrik.lundin@webrtc.org
(cherry picked from commit c6b1041d6782ca3a483ac72f42c85375230a48c8)

Review-Url: https://codereview.webrtc.org/3011193002
Cr-Original-Commit-Position: refs/heads/master@{#19773}
Change-Id: I1009622020192e24e6dfb1306498db529d03933d
Reviewed-on: https://webrtc-review.googlesource.com/1563
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/62@{#10}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}
[modify] https://crrev.com/a37a7099bf92fbe9366dee4abeec53b888785b20/webrtc/modules/audio_processing/aec3/render_delay_controller.cc
[modify] https://crrev.com/a37a7099bf92fbe9366dee4abeec53b888785b20/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc

Comment 8 by peah@chromium.org, Sep 15 2017

Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 18 2017

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62
Merged - removing label

Sign in to add a comment