New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763739 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

video_VideoDecodeAccelerator is failed on kevin.

Project Member Reported by hiroh@chromium.org, Sep 11 2017

Issue description

From R-63-9924.0.0,  video_VideoDecodeAccelerator started to be failed on kevin.

https://wmatrix.googleplex.com/failures/video?platforms=kevin&builds=R63-9928.0.0
 
Cc: tfiga@chromium.org
Components: OS>Kernel>Video
Labels: videoshortlist

Comment 2 Deleted

Comment 3 by tfiga@chromium.org, Sep 11 2017

It looks like the libdrm rebase changed drm_format_modifier struct in an incompatible way. See  issue 763760  for more details.

The workaround CL that brings back the old structure: crosreview.com/657791

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-chromeos-2.4.83
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/libdrm/+/8b82aa2cbd013ebe8027590974235170d6c63dc8

commit 8b82aa2cbd013ebe8027590974235170d6c63dc8
Author: Tomasz Figa <tfiga@chromium.org>
Date: Tue Sep 12 08:12:09 2017

HACK: Revert drm_format_modifier API back to the one used in our kernels

It looks like the modifier API is already present in upstream headers, as per
the libdrm commit below.

https://cgit.freedesktop.org/mesa/drm/commit/?id=7ec689a5406a4c5f468e126007c5aa9d72dd7f59

Moreover, it is binary-incompatible with the API used currently in ChromeOS,
added in following CL.

https://chromium-review.googlesource.com/419833

Since our kernels still use the old, incompatible API and transitioning
Chrome, one of the users, between incompatible interfaces have known to
introduce a lot of problems, let's temporarily revert back to the legacy
API.

BUG= chromium:763739 
BUG= chromium:763760 
TEST=test_that kevin video_VideoDecodeAccelerator

Change-Id: I1959d937cfda360f143f6ce3b7181f9686db29ef
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/657791
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/8b82aa2cbd013ebe8027590974235170d6c63dc8/include/drm/drm_mode.h

Comment 5 by hiroh@chromium.org, Sep 13 2017

Status: Verified (was: Started)
The test has been passed since the above CL is merged.

Sign in to add a comment