Issue metadata
Sign in to add a comment
|
Touch bar back/forward buttons not working
Reported by
ivan.fe...@gmail.com,
Sep 10 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36 Steps to reproduce the problem: 1. Open Chrome 2. Visit page 3. back/forward buttons on touch bar do not navigate back or forward What is the expected behavior? Navigate back/forward What went wrong? The back/forward buttons on the touch bar remain greyed out and are non-functional. Did this work before? Yes Chrome version: 61.0.3163.79 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Sep 10 2017
New detail: Occasionally the back button will function, though it will display as active even if there is no history.
,
Sep 11 2017
Sarah can you please take a look at this bug, As of now I don't have the touch bar machine. Note : I haven't checked this but based on user input as regression I am tagging the bug as stable blocker for now.
,
Sep 11 2017
,
Sep 11 2017
,
Sep 11 2017
I know what the problem is. Let me work on a fix
,
Sep 11 2017
Please find the behavior on touchbar on different Chrome channels : Stable/Beta(M61) : Back button works fine where on Forward is broken Dev(62.0.3202.9)/Canary(63.0.3212.0) : Both Back/Forward buttons are disabled Note : I am not bisecting since Sarah mentioned she is working on the fix and knows what's going on.
,
Sep 11 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f508048a1ba16a303adf5338491d9e92edffcda9 commit f508048a1ba16a303adf5338491d9e92edffcda9 Author: spqchan <spqchan@chromium.org> Date: Mon Sep 11 20:23:29 2017 [Mac] Update touch bar controls in each page load update Update the back/forward and star items in the touch bar when the page load state is updated. Bug: 763730 Change-Id: I77da6d9546e02c98ec1e8a2d65315e711bf74a03 Reviewed-on: https://chromium-review.googlesource.com/661055 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501019} [modify] https://crrev.com/f508048a1ba16a303adf5338491d9e92edffcda9/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
,
Sep 12 2017
WRT to comment #10. Retested the above issue on latest Canary #63.0.3213.0 on Mac Touch Bar (10.12.1) and unable to see touch buttons on touch bar. Chrome Version: 63.0.3213.0 (Official Build)58ee71082b735f6dae76665b444d534d9832b45c-refs/heads/master@{#501132} (64-bit). OS: Mac Touch Bar(10.12.1). Attaching a screenshot for Latest Canary. Thank You!
,
Sep 12 2017
Rechecked this issue on Chrome version #63.0.3213.0 on MAC touch bar 10.12.6 and observed that touch buttons on touch bar are working fine. Able to view front and back navigation Bar. Screen Shot attached. Adding TE-verified labels for M63. Note: In previous comment OS version was MAC 10.12.1 and in current comment MAC Version used was 10.12.6. Could this be related. Can some one confirm. Thanks.!
,
Sep 12 2017
Missed in Above comment, Front and back navigation is also working fine using touch bar on MAC 10.12.6, Chrome version 63.0.3213.0. Thanks.!
,
Sep 12 2017
,
Sep 12 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
Justification: This fixes the UI bug and should be safe to merged. This was tested thoroughly and does not cause any crashes AFAIK
,
Sep 12 2017
Unable to reproduce the issue in #11
,
Sep 12 2017
Approving merge to M61 branch 3163 based on comments #12, #13, #16 and #17. Please merge ASAP. Thank you.
,
Sep 12 2017
This also needs to be merged to M62. Please request a merge.
,
Sep 12 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/300c8bdaec048cf8b4af62419641275af0188945 commit 300c8bdaec048cf8b4af62419641275af0188945 Author: spqchan <spqchan@chromium.org> Date: Tue Sep 12 20:25:15 2017 [Mac] Update touch bar controls in each page load update Update the back/forward and star items in the touch bar when the page load state is updated. (cherry picked from commit f508048a1ba16a303adf5338491d9e92edffcda9) Bug: 763730 Change-Id: I77da6d9546e02c98ec1e8a2d65315e711bf74a03 Reviewed-on: https://chromium-review.googlesource.com/661055 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501019} Reviewed-on: https://chromium-review.googlesource.com/663842 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1174} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/300c8bdaec048cf8b4af62419641275af0188945/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1ef15db9ca06f76fe4f48836f1cacc20142f845 commit d1ef15db9ca06f76fe4f48836f1cacc20142f845 Author: Sarah Chan <spqchan@chromium.org> Date: Tue Sep 12 21:42:22 2017 Revert "[Mac] Update touch bar controls in each page load update" This reverts commit 300c8bdaec048cf8b4af62419641275af0188945. Reason for revert: Compile error Original change's description: > [Mac] Update touch bar controls in each page load update > > Update the back/forward and star items in the touch bar when the > page load state is updated. > > (cherry picked from commit f508048a1ba16a303adf5338491d9e92edffcda9) > > Bug: 763730 > Change-Id: I77da6d9546e02c98ec1e8a2d65315e711bf74a03 > Reviewed-on: https://chromium-review.googlesource.com/661055 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sarah Chan <spqchan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#501019} > Reviewed-on: https://chromium-review.googlesource.com/663842 > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/branch-heads/3163@{#1174} > Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} TBR=spqchan@chromium.org Change-Id: Idd163fb061bef4c3f41319ee8e361883fd91e859 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763730 Reviewed-on: https://chromium-review.googlesource.com/663947 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1177} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d1ef15db9ca06f76fe4f48836f1cacc20142f845/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8aab5215ed9c3461cd2a12b432beaa9a5f6b59b commit d8aab5215ed9c3461cd2a12b432beaa9a5f6b59b Author: spqchan <spqchan@chromium.org> Date: Tue Sep 12 22:07:05 2017 [Mac] Update touch bar controls in each page load update Update the back/forward and star items in the touch bar when the page load state is updated. (cherry picked from commit f508048a1ba16a303adf5338491d9e92edffcda9) Bug: 763730 Change-Id: I6fcbfde08c3230c497953215eb688e521eef495b Reviewed-on: https://chromium-review.googlesource.com/663766 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1178} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d8aab5215ed9c3461cd2a12b432beaa9a5f6b59b/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
,
Sep 14 2017
Rechecked this issue on Chrome version #61.0.3163.91 on MAC touch bar 10.12.6 and observed that touch buttons on touch bar are working fine. Able to view and navigate using front and back navigation Bar. Adding TE-verified labels for M61.
,
Sep 14 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14 2017
Approving merge to M62. Branch:3202
,
Sep 14 2017
This patch is now pushing out to stable channel in version 61.0.3163.91 for Desktop (Win,Mac & Linux).
,
Sep 14 2017
Thank you for fixing the bug. Requesting postmortem for this please see go/chrome-postmortems for the process to follow.
,
Sep 14 2017
Thanks! I'll work on one
,
Sep 15 2017
Thank you spqchan@.
,
Sep 18 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a534c0e12318d847ee01f500351ec51a6f266d8 commit 7a534c0e12318d847ee01f500351ec51a6f266d8 Author: spqchan <spqchan@chromium.org> Date: Mon Sep 18 17:09:43 2017 [Mac] Update touch bar controls in each page load update Update the back/forward and star items in the touch bar when the page load state is updated. (cherry picked from commit f508048a1ba16a303adf5338491d9e92edffcda9) Bug: 763730 Change-Id: I77da6d9546e02c98ec1e8a2d65315e711bf74a03 Reviewed-on: https://chromium-review.googlesource.com/661055 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501019} Reviewed-on: https://chromium-review.googlesource.com/671486 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#291} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/7a534c0e12318d847ee01f500351ec51a6f266d8/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
,
Sep 18 2017
,
Sep 20 2017
Verified this issue on MacBook Pro with touch bar using chrome latest M62-62.0.3202.29 by following steps mentioned in the original comment, Observed able to navigate the page forward and backward as expected. Hence adding TE-Verified label. Note: Unable to go back/forward using touch bar in chrome after opening a New Tab, filed a separate issue 766969 . Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gov...@chromium.org
, Sep 10 2017Labels: Needs-Triage-M61 M-61