New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763718 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 28 days ago
Closed: Dec 2017
Cc:
█ chenwilliam@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Layout test http/.../livelocation-main-frame-navigated.html is machine-dependent

Project Member Reported by qyears...@chromium.org, Sep 10 2017 
Tests:
 http/tests/inspector/bindings/livelocation-main-frame-navigated.html
 virtual/mojo-loading/http/tests/inspector/bindings/livelocation-main-frame-navigated.html

Example output:

Running: navigateMainFrame
[ UPDATE ]  LiveLocation-css: null
[ UPDATE ]  LiveLocation-css: null
[ UPDATE ]  LiveLocation-js: http://127.0.0.1:8000/inspector/bindings/resources/sourcemap-script.js:0:0
[ UPDATE ]  LiveLocation-js: debugger:///VM48 sourcemap-script.js:0:0
Page reloaded.
[  GET   ]  LiveLocation-js: null
[  GET   ]  LiveLocation-css: null

The "VM48" part seems to be machine-dependent, and so it doesn't pass consistently on the bots.

Comment 1 by qyears...@chromium.org, Sep 10 2017

Description: Show this description

Comment 2 by lushnikov@chromium.org, Nov 14 2017

Owner: lushnikov@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/859e30e83ed75878b43778e873c26308f5b16953

commit 859e30e83ed75878b43778e873c26308f5b16953
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Wed Nov 15 01:47:02 2017

DevTools: migrate bindings/ tests

This patch migrates a bunch of bindings tests to the new test runner.
It also starts cleaning up output of livelocation test, unflaking it
across platforms.

BUG= chromium:763718 
R=dgozman, chenwilliam

Change-Id: I416176ecf7c16c85edec37ef56963581e559653d
Reviewed-on: https://chromium-review.googlesource.com/767617
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516553}
[modify] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated.html
[add] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/livelocation-main-frame-navigated.js
[modify] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings-expected.txt
[rename] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-bindings.js
[modify] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator-expected.txt
[rename] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator.js
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/linux/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac-mac10.10/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac-mac10.11/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/win/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/win7/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[delete] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/devtools/bindings/livelocation-main-frame-navigated-expected.txt
[modify] https://crrev.com/859e30e83ed75878b43778e873c26308f5b16953/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/BindingsTestRunner.js

Comment 4 by lushnikov@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment