New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763711 link

Starred by 9 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Need Test for auto-highlighting when opening new tab (with NTP replacement extension)

Reported by tzjia...@gmail.com, Sep 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36

Steps to reproduce the problem:
1. Open a new tab
2. Notice that the text in the url bar is not selected

2. Notice that the text in the url bar is not selected

What is the expected behavior?
The url should be automatically selected.

What went wrong?
The url is not automatically selected.

Did this work before? Yes Chrome 60

Chrome version: 61.0.3163.79  Channel: stable
OS Version: 16.0.4
Flash Version: 

This seems minor but is extremely annoying since I've always built the habit of opening a new tab and typing straight away and now I have to open a new tab, select the url, and then type....
 
Labels: Needs-Bisect Needs-Triage-M61
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Ubuntu 16.04 using chrome reported version# 61.0.3163.79 as per the steps mentioned in C#0.

URL bar is auto highlighted upon new tab.We are able to type immediately after opening a new tab.

Please find the attached screencast for reference & let us know your observations on the same.
Thanks..!

763711.webm
1.7 MB View Download

Comment 3 by tzjia...@gmail.com, Sep 12 2017

Hello, this issue occurs when a home page is set on new tabs. In the screenshare you attached, there is no url being populated when opening a new tab, so there is nothing to highlight. The problem is that if a url is specified automatically for new tabs, then typing will prepend the URL rather than replacing it.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 12 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
Thanks for the reply.
Tested the issue as per C#3.

Steps:
-----
1. Launch chrome
2. Navigate to chrome://settings
3. Enable 'Show home button' & deselect 'New Tab page' radio button
4. Enter any URL ( Ex: www.youtube.com)
5. Now click on 'new tab'
6. Click on 'Home' button (beside address bar)
7. Observed that page redirected to the above URL in step 4

But no URL is highlighted on address bar

Similar behavior observed on M60 also. Please find the attached screencast & let us know if we miss any steps to reproduce the issue from our end.

763711-M60webm
5.8 MB View Download

Comment 6 by tzjia...@gmail.com, Sep 13 2017

Hello,

No that is not really what I meant.

I just realized that I've been using a chrome extension that sets a custom URL when opening a new tab as soon as you open the new tab. So this functionality would not officially be supported. It would be nice to force-highlight the URL whenever a new tab is opened (like in versions <= 60), but I suppose this is more of a feature request rather than a bug.

Why doesn't Chrome offer the ability to set a URL for new tabs by default? Is it a security issue?

Thanks
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Bisect -Type-Bug-Regression M-63 Type-Feature
Status: Untriaged (was: Unconfirmed)
Thanks for the reply.
As per comment#6,seems this is a feature request.Hence marking it as Untriaged to get more inputs from dev. Removing 'Needs-Bisect' label for now.

Comment 9 by must...@miswave.com, Sep 19 2017

This has broken all new tab extensions.
Cc: hdodda@chromium.org
 Issue 770282  has been merged into this issue.
Components: UI>Browser>NewTabPage UI>Browser>Omnibox
Labels: -Pri-2 Needs-Bisect Pri-3
Owner: treib@chromium.org
Status: Assigned (was: Untriaged)
*sigh*

It feels like this breaks regularly (ref  bug 362322 ,  bug 471635 ).  treib@, can you look into the cause this time?  And perhaps we can get a test written to prevent this from regressing yet again?

Testing team - this used to work.  Can we get a bisect please?
Here's a popular NTP replacement extension to test with:
https://chrome.google.com/webstore/detail/speed-dial-fvd-new-tab-pa/llaficoajjainaijghjlofdfmbjpebpa?utm_source=chrome-ntp-icon

Summary: No auto-highlighting when opening new tab (with NTP replacement extension) (was: No auto-highlighting when opening new tab)

Comment 13 by treib@chromium.org, Dec 13 2017

Labels: -Type-Feature -Pri-3 OS-Mac OS-Windows Pri-2 Type-Bug-Regression
Sure, I can take a look, but I'll wait for that bisect first.

In the meantime, re-labeling per the comments above. I'm also assuming this affects all desktop platforms, not just Linux.
Cc: krajshree@chromium.org
Labels: -Needs-Bisect Triaged-ET Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome latest stable #63.0.3239.84 and latest canary #65.0.3293.0 as per issue id: 471635(comment #11) .

Attached screen casts for reference.

Following are the steps followed to reproduce the issue.
------------
1. Installed a New Tab replacement extension, e.g. https://chrome.google.com/webstore/detail/new-tab-apps-page/fgfnhkkcobfgplgakkclighaejoimhph
2. Opened a new tab
3. Observed that omnibox received focus and entire omnibox text was highlighted.

treib@ - Could you please check the screen casts of both chrome reported version #61.0.3163.79 and latest stable #63.0.3239.84 and please let us know your inputs.
Removing the Needs-Bisect label as it is no more reproducible in latest stable. Please feel free to add the same if required.

Thanks...!!
763711@M63stable.mp4
518 KB View Download
763711@M61reported_version.mp4
503 KB View Download

Comment 15 by treib@chromium.org, Dec 14 2017

Cc: treib@chromium.org
Owner: mpear...@chromium.org
Thanks! Indeed, it looks like this was already fixed again in M63. So I guess there's nothing left to do here except write a regression test. This seems like something that can't be covered well by unit tests, and since it's related on focus, it'd have to be in interactive_ui_tests. But all the Omnibox UI tests seem to be flaky right now, see bug 751031. :(
Back over to mpearson for triage among the Omnibox folks.

(I'd still be curious to know what broke this, and what fixed it again, but it's maybe not worth the effort to investigate further.)
Labels: -Needs-Feedback
Owner: tommycli@chromium.org
Summary: Need Test for auto-highlighting when opening new tab (with NTP replacement extension) (was: No auto-highlighting when opening new tab (with NTP replacement extension))
Over to tommycli, as he's thinking about writing / improving / fixing Omnibox UI tests.

(Feel free to negotiate with other LAX folks to hand this off.  I feel like this has broken, what, three times in the past, and so we definitely should have a test here.)
Labels: zine-triaged

Sign in to add a comment