New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763701 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Seach text in source mapped files

Reported by ruvat...@gmail.com, Sep 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

Steps to reproduce the problem:
1. Open any webapp with source mapped JS files (for example https://github.com/reactjs/redux/tree/master/examples/todos
React/Redux Application packed by webpack and babel)
2. Open DevTools
3. Open Seach Tool (by files) on Sources tab (Ctrl+Shift+F)
4. Try to find the substring, that is guaranteed to be present in source files mapped by source map tech
5. the matches could not be found
6. open taget sorce file in Source tab Navigator => Sources
7. Select file, contains the substring, already tryed to search
8. Try to find substring in file localy (Ctrl + F)
9. Thats OK

What is the expected behavior?
Target substring that is guaranteed to be present in source files mapped by source map tech, is present in search results, as it does for basic source files

What went wrong?
Search substring in sources as mapped by source map tech don't work

Did this work before? No 

Chrome version: 95c454326a7a3153e984e50a4719924968490717-refs/branch-heads/3112@{#744}  Channel: stable
OS Version: 10.0
Flash Version: 26.0.0.151
 
Developer Tools.png
131 KB View Download
Cc: pnangunoori@chromium.org
Labels: Needs-Feedback
@ruvata34 -- Thanks for reporting this issue. Could you please provide sample HTML file or extension with test data to reproduce this issue.

Thanks in advance.

Comment 2 by ruvat...@gmail.com, Sep 13 2017

You can use sample (example React/Redux app) from "Steps to reproduce the problem", and see screenshot for curent substring sample.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "pnangunoori@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Milestone
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4b65a8e2f799e9414b8ed400d06e873ed29496

commit cb4b65a8e2f799e9414b8ed400d06e873ed29496
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Tue Dec 12 00:54:52 2017

DevTools: start searching in sourcemaps

This patch teaches global search to search in sourcemap sources
as well.

BUG= 763701 

Change-Id: I3062e21cf0a589d02f6926b8ec3785eca15b879a
Reviewed-on: https://chromium-review.googlesource.com/820653
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523277}
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-page.html
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-sass.scss
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-script.js
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-script.js.map
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-style.css
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-style.css.map
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/resources/sourcemap-typescript.ts
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap-expected.txt
[add] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/LayoutTests/http/tests/devtools/search/search-in-sourcemap.js
[modify] https://crrev.com/cb4b65a8e2f799e9414b8ed400d06e873ed29496/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js

Status: Fixed (was: Assigned)

Sign in to add a comment