New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763700 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: HTML Document compressed size is not correct

Reported by olive...@gmail.com, Sep 10 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36

Steps to reproduce the problem:
1. open "https://osx.dianping.com/app/overseas-info/food-rank.html?rankCityId=2372&utm_source=__28nzr"
2. open developer tools
3. switch to "Network" panel, check the document request compressed size is not correct

What is the expected behavior?
it should display the correct compressed size

What went wrong?
it doesn't display the correct compressed size
And this page is using application cache, but "Disable Cache" feature doesn't work either.

These two things work correctly on Chrome 60 and previous.
It breaks on Chrome 61

Did this work before? Yes Chrome 60

Chrome version: 61.0.3163.79  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 26.0 r0
 
bug.jpg
214 KB View Download
Cc: rbasuvula@chromium.org
Labels: Needs-Triage-M61 Needs-Feedback
Tested in chrome #61.0.3163.79 and Canary #63.0.3212.0 on Mac 10.12.6 and not able to reproduce the issue.Please find the screen shots for your reference.

@ oliverzy: Could you please let me know if i have missed anything and if possible,Please create new profile without extensions and apps.Re-check once and let us know the observations and expected compressed size of the issue which would help us to triage the issue further.

Thanks in Advance.
763700.png
727 KB View Download

Comment 2 by olive...@gmail.com, Sep 11 2017

The issue only seems to happen for the main html document resource, I marked it as red circle.
As you can see, it shows 76.1K.
However, if you check the Content-Length, it is actually less than 30K.

I attached another screenshot for you.
111.png
274 KB View Download
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 11 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Bisect
Labels: -Needs-Bisect M-63 OS-Linux OS-Windows
Owner: eostroukhov@chromium.org
Status: Assigned (was: Unconfirmed)
Tested in chrome Beta #61.0.3163.79 and canary #63.0.3213.0 on Mac 10.12.6,Ubuntu 14.04 & Win 7 able to reproduce the issue.
Unable to provide the per revision bisect and Normal bisect as getting all good builds even changing the bad range.So providing the manual bisect below are the Bisect Details:

Bisect Info:
=============
Good Build: 61.0.3163.0(Revision - 488528)
Bad Build: 62.0.3164.0(Revision - 488823)

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/61.0.3163.0..62.0.3164.0?pretty=fuller&n=10000
Suspect: https://chromium.googlesource.com/chromium/src/+/9e2bedd723e9a4a67e9623861de64c0e5d6d4d2f

From the CL above, assigning the issue to the concern owner

@eostroukhov: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-On:https://chromium-review.googlesource.com/560602

Thank You!

Comment 6 by jam@chromium.org, Sep 13 2017

Cc: clamy@chromium.org dgozman@chromium.org arthurso...@chromium.org nasko@chromium.org
Labels: Proj-PlzNavigate
This sounds like it's related to PlzNavigate (browser-side-navigation in about:flags).

If you're reproducing locally, make sure to turn on that flag.

I can verify that it's fixed without PlzNavigate, so it's a bug related to it.
I think it might be related to  https://crbug.com/760924 
Owner: caseq@chromium.org
Cc: jakearchibald@chromium.org allada@chromium.org addyo@chromium.org caseq@chromium.org
 Issue 771167  has been merged into this issue.
 Issue 776322  has been merged into this issue.
More reports about gzip'ed size being wrong in  issue 776322 .
 Issue 775773  has been merged into this issue.
Labels: -Pri-2 Pri-1
Summary: DevTools: HTML Document compressed size is not correct (was: HTML Document compressed size is not correct )
Bumping to P1.

Comment 14 by clamy@chromium.org, Oct 24 2017

As explained over email, we do have plans to change the delivery mechanic for the main resource in PlzNavigate. This is  issue 740130 . I do hope that it will fix this particular issue. However, while we're hoping to land in Q4, it may not arrive right away. So we might want to do a fix for the actual mechanism (ie with blob urls) to ensure this bug is fixed in the meantime.
FWIW, I think this can also cause things served from disk cache to not have (from disk cache) in the UI --- and likely also affects the resource timing API? 

Comment 16 by y...@yoav.ws, Nov 13 2017

Cc: sc00335...@techmahindra.com
 Issue 773762  has been merged into this issue.

Comment 17 by y...@yoav.ws, Nov 13 2017

According to a test ran by jeroenvdb on the WebPerformance slack channel [1] the same values are also present in Navigation Timing.

[1] https://webperformance.slack.com/files/U0PFN4K54/F7ZA8GBLK/picture_2017-11-13_at_17.08.02.jpg
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b

commit 81f89b3b8fbb90742d88ffef7d82a561cfee3c5b
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Nov 13 19:52:45 2017

Associate actual response headers and undecoded size with streams

This associates original HttpRequestInfo and encoded data size
with Stream in the form of StreamMetadata, so that StreamURLRequestJob
could return actual values instead of the bogus ones that it currently
makes up.

This fixes a problem with reporting actual transferred bytes in
DevTools' network panel and removes the need for at last some of
the stream override params in WebURLLoaderImpl.

Bug:  763700 ,  705744 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8493bbe464cd9a81a0864e5bcc9afd8b19aea3c5
Reviewed-on: https://chromium-review.googlesource.com/744290
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516012}
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/loader/stream_resource_handler.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/loader/stream_writer.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/loader/stream_writer.h
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream.h
[add] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream_metadata.h
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream_url_request_job.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream_url_request_job.h
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/browser/streams/stream_url_request_job_unittest.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/net/url_request/url_request_job.cc
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/net/url_request/url_request_job.h
[modify] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[add] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-xfer-size-expected.txt
[add] https://crrev.com/81f89b3b8fbb90742d88ffef7d82a561cfee3c5b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-xfer-size.js

Cc: nbeloglazov@google.com

Comment 20 by caseq@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
this is huge. caseq, much thanks to making this fix happen!

is this something we could merge to 63?

Comment 22 by caseq@chromium.org, Nov 15 2017

IU'm sure there will be at lase _some_ merge conflicts, but still should be possible. Let it bake for some time on dev channel, we need to make sure it doesn't regress anything, then we'll see how bad the merge would be.

Comment 23 by l...@chromium.org, Nov 17 2017

Cc: divya.pa...@techmahindra.com
 Issue 785350  has been merged into this issue.

Comment 24 by b...@chromium.org, Nov 22 2017

 Issue 787346  has been merged into this issue.

Comment 25 by b...@chromium.org, Nov 22 2017

Cc: krajshree@chromium.org
 Issue 787506  has been merged into this issue.

Sign in to add a comment