New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763675 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference WRITE in es2::Program::setUniform1iv

Project Member Reported by ClusterFuzz, Sep 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4928460350029824

Fuzzer: inferno_twister_c
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference WRITE
Crash Address: 0x00000000
Crash State:
  es2::Program::setUniform1iv
  glUniform1uiv
  gpu::gles2::Program::ClearUniforms
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=500358:500415

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4928460350029824

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org jie.a.c...@intel.com jmad...@chromium.org
Labels: Test-Predator-Wrong-CLs M-63
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "Program.cpp" assigning to the concern review owner.

Suspecting Commit#
https://chromium.googlesource.com/angle/angle.git/+/880683b17381d11f6fab162a7e1604fc94ec0279

@geofflang -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
 Issue 763525  has been merged into this issue.
Cc: geoffl...@chromium.org
Owner: zmo@chromium.org
Mo, could you re-assign or look at this?
Project Member

Comment 4 by ClusterFuzz, Sep 14 2017

Labels: OS-Linux

Comment 5 by zmo@chromium.org, Sep 28 2017

Owner: capn@chromium.org
capn: the violation happens in SwiftShader. Can you take a look?

Comment 6 by capn@chromium.org, Sep 29 2017

Cc: capn@chromium.org
Owner: sugoi@chromium.org
Alexis, this is also blamed on the roll that enabled WebGL 2 for SwiftShader. Please have a look.
Project Member

Comment 7 by ClusterFuzz, Oct 1 2017

Components: Internals>GPU>Internals
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/ec5da193b1c29dc8bee19dcc8fe297901ff74911

commit ec5da193b1c29dc8bee19dcc8fe297901ff74911
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Oct 06 19:12:10 2017

Do not assign a location to uniform block members

Uniform block members do not get a uniform location, since they
cannot be set (or get) through regular glUniform* functions. These
are instead always set using uniform buffers.

 Bug chromium:763675 , chromium:763698 , chromium:771639 

Change-Id: Icf65eba3faab420c63f70af66f828a786e3fc446
Reviewed-on: https://swiftshader-review.googlesource.com/13068
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

[modify] https://crrev.com/ec5da193b1c29dc8bee19dcc8fe297901ff74911/src/OpenGL/libGLESv2/Program.cpp
[modify] https://crrev.com/ec5da193b1c29dc8bee19dcc8fe297901ff74911/src/OpenGL/libGLESv2/Program.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0794182a95e64e07c4d351ff51543aa1ad4722a

commit f0794182a95e64e07c4d351ff51543aa1ad4722a
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Oct 06 21:21:18 2017

Roll SwiftShader 9d56da2..ec5da19

https://swiftshader.googlesource.com/SwiftShader.git/+log/9d56da2..ec5da19

BUG= chromium:763675 , chromium:763698 , chromium:771639 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: If9a21ac28f65767880b09455f67f3364750dc2d3
Reviewed-on: https://chromium-review.googlesource.com/705914
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507181}
[modify] https://crrev.com/f0794182a95e64e07c4d351ff51543aa1ad4722a/DEPS

Project Member

Comment 10 by ClusterFuzz, Oct 7 2017

ClusterFuzz has detected this issue as fixed in range 507143:507182.

Detailed report: https://clusterfuzz.com/testcase?key=4928460350029824

Fuzzer: inferno_twister_c
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference WRITE
Crash Address: 0x00000000
Crash State:
  es2::Program::setUniform1iv
  glUniform1uiv
  gpu::gles2::Program::ClearUniforms
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=500358:500415
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=507143:507182

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4928460350029824

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
Project Member

Comment 12 by ClusterFuzz, Oct 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4928460350029824 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment