New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763664 link

Starred by 3 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 644851



Sign in to add a comment

Implement SkiaRenderer::GenerateMipmap.

Project Member Reported by reve...@chromium.org, Sep 9 2017

Issue description

Needed to avoid aliasing in some Chrome OS UI effect. See issue 757020 from more details.
 
Cc: weiliangc@chromium.org bsalomon@chromium.org
Do we need extra generation step? Or is setting should have mipmap to true while creating the render pass SkSurface enough?

https://cs.chromium.org/chromium/src/components/viz/service/display/skia_renderer.cc?sq=package:chromium&l=807
Blocking: 644851
Components: Internals>Skia>Compositing Internals>Compositing
Labels: Proj-Vulkanize
Owner: weiliangc@chromium.org
Cc: bsalo...@google.com
Looking at code, when SkSurface is created from MakeRenderTarget, the mipmap information is passed in: https://cs.chromium.org/chromium/src/components/viz/service/display/skia_renderer.cc?sq=package:chromium&l=1333

And when we use the RenderPass, we snap a SkImage, which in Skia would comply with appropriate mip map information:https://cs.chromium.org/chromium/src/third_party/skia/src/image/SkSurface_Gpu.cpp?g=0&l=107

I think I just need to remove the NOTIMPLEMENTED but say it's a noop?

Comment 5 by weiliangc@chromium.org, Today (18 hours ago)

Test for mipmap is the GLRendererPixelTest.TrilinearFiltering.

Sign in to add a comment