New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763657 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: page.captureScreenshot rounds clipping area to even numbers

Project Member Reported by lushnikov@chromium.org, Sep 9 2017

Issue description

Downstream bug in Puppeteer: https://github.com/GoogleChrome/puppeteer/issues/733

Protocol command Page.captureScreenshot rounds clipping area to even numbers.

Puppeteer repro on Mac OS X:


const puppeteer = require('puppeteer');
(async() => {
  const browser = await puppeteer.launch()
  const page = await browser.newPage()
  await page.screenshot({
    clip: {
      x: 0,
      y: 0,
      width: 11,
      height: 11
    },
    path: 'clip.png'
  });
  await page.close();
  browser.close();
})();



Expected: clip.png to be 11x11
Actual: clip.png is 12x12
 
Description: Show this description
Owner: lushnikov@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd93b4edee19058ed1352e6e10b684a789cbc21

commit fcd93b4edee19058ed1352e6e10b684a789cbc21
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Oct 20 01:19:33 2017

DevTools: fix screenshot clipping on retina displays

Currently, computation of screenshot dimensions has a rounding error
that surfaces on retina displays.

This patch starts rounding screenshot dimensions up and then truncating
them if necesseary.

Bug:  chromium:763657 
Change-Id: I8953c32af76d216893fb43a62eaa440a15e2652a
Reviewed-on: https://chromium-review.googlesource.com/726746
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510285}
[modify] https://crrev.com/fcd93b4edee19058ed1352e6e10b684a789cbc21/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/fcd93b4edee19058ed1352e6e10b684a789cbc21/content/browser/devtools/protocol/page_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment