New issue
Advanced search Search tips

Issue 763650 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

no type named 'string_view' in namespace 'std' inline uint32_t Crc32c(const std::string_view& string_view) {

Reported by sl1pk...@gmail.com, Sep 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.0 Safari/537.36

Steps to reproduce the problem:
1. download chromium-62.0.3202.9 (dev channel)
2. prepare environment for build with bundled clan downloaded from tools/clang/scripts/update.py (312679)
3. start build

What is the expected behavior?
build

What went wrong?
fail build

[5483/32939] /tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj / third_party / crc32c / crc32c / crc32c.od -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA = 1 -DUSE_PANGO = 1 -DUSE_CAIRO = 1 -DUSE_GLIB = 1 -DUSE_NSS_CERTS = 1 -DUSE_X11 = 1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION = \ "310694-2 \" -D_FILE_OFFSET_BITS = 64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED = 0 -DHAVE_MM_PREFETCH = 1 -DHAVE_SSE42 = 1 -DHAVE_BUILTIN_PREFETCH = 1 -DHAVE_STRONG_GETAUXVAL = 1 -I ../ .. igen -I ../ .. / third_party / crc32c / config -I ../ ../ third_party / crc32c / src / include -fno-strict-aliasing -param = ssp-buffer-size = 4 -file-protector -Wno-builtin-macro-redefinido -D__DATE __ = -D__TIME __ = -D__TIMESTAMP __ = -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march = x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c + + 11-narrowing -Wno-covered- switch-default -Wno-innecesario-declaración-interna -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused- lambda-capture -Wo-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -function-sections -fomit-frame-pointer -g0 -fvisibility = hidden -Xclang -load - Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.tan -Xclang -add-plugin -Xclang encontrar-mal-construye -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-puntero -Xclang -plugin-arg-find-bad-constructs -Xclang check -ipc -Wheer-higiene -Wstring-conversion -Wututological-overlap-compare -std = gnu ++ 14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE = 2 -march = nativo -O2 -pipe - fstack-protector-strong -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o/third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o/third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o
FALLA: obj / third_party / crc32c / crc32c / crc32c.o
/tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj / third_party / crc32c / crc32c / crc32c.od -DV8_DEPRECATION_WARNINGS -DUSE_UDEV - DUSE_AURA = 1 -DUSE_PANGO = 1 -DUSE_CAIRO = 1 -DUSE_GLIB = 1 -DUSE_NSS_CERTS = 1 -DUSE_X11 = 1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION = \ "310694-2 \" -D_FILE_OFFSET_BITS = 64 -D_LARGEFILE_SOURCE - D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED = 0 -DHAVE_MM_PREFETCH = 1 -DHAVE_SSE42 = 1 -DHAVE_BUILTIN_PREFETCH = 1 -DHAVE_STRONG_GETAUXVAL = 1 -I ../ .. igen -I ../../ THIRD_PARTY / crc32c / config -I ../ ../ third_party / crc32c / src / include -fno-strict-aliasing -param = ssp-buffer-size = 4 -file-protector -Wno-builtin-macro-redefinido -D__DATE __ = -D__TIME __ = -D__TIMESTAMP __ = -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march = x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c + + 11-narrowing -Wno-covered- switch-default -Wno-innecesario-declaración-interna -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused- lambda-capture -Wo-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -function-sections -fomit-frame-pointer -g0 -fvisibility = hidden -Xclang -load - Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.tan -Xclang -add-plugin -Xclang encontrar-mal-construye -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-puntero -Xclang -plugin-arg-find-bad-constructs -Xclang check -ipc -Wheer-higiene -Wstring-conversion -Wututological-overlap-compare -std = gnu ++ 14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE = 2 -march = nativo -O2 -pipe - fstack-protector-strong -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o/third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o/third_party/crc32c/src/src/crc32c.cc -o obj / third_party / crc32c / crc32c / crc32c.o
En archivo incluido desde ../../third_party/crc32c/src/src/crc32c.cc:5:
En archivo incluido desde ../../third_party/crc32c/src/include/crc32c/crc32c.h:41:
En el archivo incluido desde /usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/string_view:39:
/usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/bits/c++17_warning.h:32: 2: error: Este archivo requiere soporte de compilador y biblioteca para el estándar ISO C ++ 2017. Este soporte debe estar habilitado con las opciones de compilador -std = c ++ 17 o -std = gnu ++ 17.
#error Este archivo requiere soporte para el compilador y la biblioteca \
 ^
En archivo incluido desde ../../third_party/crc32c/src/src/crc32c.cc:5:
../../third_party/crc32c/src/include/crc32c/crc32c.h:44:35: error: ningún tipo llamado 'string_view' en el espacio de nombres 'std'
inline uint32_t Crc32c (const std :: string_view & string_view) {
                             ~~~~~ ^
Se generaron 2 errores.

clang de herramientas / clang / scripts / update.py

Did this work before? N/A 

Chrome version: 62.0.3202.0  Channel: n/a
OS Version: 10.0
Flash Version: 

tested with bundled clang and system clang (4.0.1 and 5.0.0)

all in linux

refeered: https://bugs.chromium.org/p/chromium/issues/detail?id=759349
 
Components: Blink>Storage
Labels: -OS-Windows -Pri-2 -Arch-x86_64 Arch-All OS-All Pri-3
Owner: pwnall@chromium.org
Status: Started (was: Unconfirmed)

Comment 2 by sl1pk...@gmail.com, Sep 9 2017

ops. 

[5483/32939] /tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++  -MMD -MF obj/third_party/crc32c/crc32c/crc32c.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DHAVE_MM_PREFETCH=1 -DHAVE_SSE42=1 -DHAVE_BUILTIN_PREFETCH=1 -DHAVE_STRONG_GETAUXVAL=1 -I../.. -Igen -I../../third_party/crc32c/config -I../../third_party/crc32c/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong  -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj/third_party/crc32c/crc32c/crc32c.o
FAILED: obj/third_party/crc32c/crc32c/crc32c.o 
/tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++  -MMD -MF obj/third_party/crc32c/crc32c/crc32c.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DHAVE_MM_PREFETCH=1 -DHAVE_SSE42=1 -DHAVE_BUILTIN_PREFETCH=1 -DHAVE_STRONG_GETAUXVAL=1 -I../.. -Igen -I../../third_party/crc32c/config -I../../third_party/crc32c/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong  -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj/third_party/crc32c/crc32c/crc32c.o
In file included from ../../third_party/crc32c/src/src/crc32c.cc:5:
In file included from ../../third_party/crc32c/src/include/crc32c/crc32c.h:41:
In file included from /usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/string_view:39:
/usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/bits/c++17_warning.h:32:2: error: This file requires compiler and library support for the ISO C++ 2017 standard. This support must be enabled with the -std=c++17 or -std=gnu++17 compiler options.
#error This file requires compiler and library support \
 ^
In file included from ../../third_party/crc32c/src/src/crc32c.cc:5:
../../third_party/crc32c/src/include/crc32c/crc32c.h:44:35: error: no type named 'string_view' in namespace 'std'
inline uint32_t Crc32c(const std::string_view& string_view) {
                             ~~~~~^
2 errors generated.

output in LC_ALL=C
The errors above look a bit odd. Re-posting the error messages in  https://crbug.com/759349#c8 

[5483/32939] /tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++  -MMD -MF obj/third_party/crc32c/crc32c/crc32c.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DHAVE_MM_PREFETCH=1 -DHAVE_SSE42=1 -DHAVE_BUILTIN_PREFETCH=1 -DHAVE_STRONG_GETAUXVAL=1 -I../.. -Igen -I../../third_party/crc32c/config -I../../third_party/crc32c/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong  -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj/third_party/crc32c/crc32c/crc32c.o
FAILED: obj/third_party/crc32c/crc32c/crc32c.o 
/tmp/makepkg/chromium-dev/src/chromium-62.0.3202.9/third_party/llvm-build/Release+Asserts/bin/clang++  -MMD -MF obj/third_party/crc32c/crc32c/crc32c.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DHAVE_MM_PREFETCH=1 -DHAVE_SSE42=1 -DHAVE_BUILTIN_PREFETCH=1 -DHAVE_STRONG_GETAUXVAL=1 -I../.. -Igen -I../../third_party/crc32c/config -I../../third_party/crc32c/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -march=native -O2 -pipe -fstack-protector-strong  -Wno-unknown-warning-option -c ../../third_party/crc32c/src/src/crc32c.cc -o obj/third_party/crc32c/crc32c/crc32c.o
In file included from ../../third_party/crc32c/src/src/crc32c.cc:5:
In file included from ../../third_party/crc32c/src/include/crc32c/crc32c.h:41:
In file included from /usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/string_view:39:
/usr/lib64/gcc/x86_64-pc-linux-gnu/7.2.0/../../../../include/c++/7.2.0/bits/c++17_warning.h:32:2: error: This file requires compiler and library support for the ISO C++ 2017 standard. This support must be enabled with the -std=c++17 or -std=gnu++17 compiler options.
#error This file requires compiler and library support \
 ^
In file included from ../../third_party/crc32c/src/src/crc32c.cc:5:
../../third_party/crc32c/src/include/crc32c/crc32c.h:44:35: error: no type named 'string_view' in namespace 'std'
inline uint32_t Crc32c(const std::string_view& string_view) {
                             ~~~~~^
2 errors generated.

clang from tools/clang/scripts/update.py
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26327d27d809b1b5c2e3d762cf98e69afba3e815

commit 26327d27d809b1b5c2e3d762cf98e69afba3e815
Author: Victor Costan <pwnall@chromium.org>
Date: Wed Sep 13 00:38:26 2017

Bump third_party/crc32c to 1.0.3.

Bug:  763650 ,  763848 
Change-Id: Ideb5ab7ed300718458fe2665bf8af099bc56d272
Reviewed-on: https://chromium-review.googlesource.com/658838
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501485}
[modify] https://crrev.com/26327d27d809b1b5c2e3d762cf98e69afba3e815/DEPS
[modify] https://crrev.com/26327d27d809b1b5c2e3d762cf98e69afba3e815/third_party/crc32c/BUILD.gn
[modify] https://crrev.com/26327d27d809b1b5c2e3d762cf98e69afba3e815/third_party/crc32c/README.chromium

Comment 5 by pwnall@chromium.org, Sep 13 2017

Status: Fixed (was: Started)
The compilation error should be fixed now. Please let me know if that's not the case.

Comment 6 by sl1pk...@gmail.com, Sep 13 2017

same error as before. trying version 62.0.3202.18 (released yesterday)

the patch from https://chromium-review.googlesource.com/658838 failed due aready implemented(?)

but in log, that commit is not exposed https://chromium.googlesource.com/chromium/src/+log/62.0.3202.9..62.0.3202.18?pretty=fuller&n=10000

seems the https://chromium-review.googlesource.com/658838 overwrite the patch for fix this issue, i think you need update the patch on the new release

greetings

Comment 7 by sl1pk...@gmail.com, Sep 13 2017

>the patch from https://chromium-review.googlesource.com/658838 failed due aready implemented(?)

ok, searching the "blame" commits on https://chromium.googlesource.com/chromium/src.git/+log/master/third_party/crc32c, seems the content of the review https://chromium-review.googlesource.com/658838 is only for bump the version

crc32c on github, this commit (https://github.com/google/crc32c/commit/d0f929a5db87cb34d03afb0d8e8bfc95b8f786e3) is the fix for this issue, rigth?

then can confirm do nothing (same error when build)

tested again with bundled clang (clang-310694-2) and system clang (5.0.0)

greetings

Comment 8 by pwnall@chromium.org, Sep 14 2017

M62 was branched before https://crrev.com/c/658838 landed, and does not include the patch. If you really need to build M62 on Linux, I'd suggest setting use_sysroot=true (which I think is the default?) as a workaround. The compilation error should not show up on master.

Comment 9 by sl1pk...@gmail.com, Sep 14 2017

Dev channel is now M63, this release include the patch, but do nothing, same issue

Greetings

Comment 10 by sl1pk...@gmail.com, Sep 14 2017

I mean, dev channel is updated to 63.0.3213.3 yesterday (hours after 62.0.3202.18 release), and have the same issue

Greetings

Comment 11 by sl1pk...@gmail.com, Sep 14 2017

ok. now I can understand all

63.0.3213.3 also don't include https://github.com/google/crc32c/commit/d0f929a5db87cb34d03afb0d8e8bfc95b8f786e3

appling the commit directly by hand to 63.0.3213.3 this can solve te problem. I say "can" because with the new release build fail in other part outside of this bug

when I can fix the issue (problably throught patch from gentoo github repository(bootstrap-r18.patch (?)) i'll posted the result

sorry for the last noise

greetings

Comment 12 by sl1pk...@gmail.com, Sep 15 2017

ok. tested and fixed. again, sorry for the lasst noise

greetings :)

Sign in to add a comment