New issue
Advanced search Search tips

Issue 763636 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Sep 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

WPT: Import and enable tests for CSS Namespaces, Conditional

Project Member Reported by ericwilligers@chromium.org, Sep 9 2017 
The tests are currently skipped during WPT imports:
external/wpt/css/CSS2/cascade [ Skip ]
external/wpt/css/CSS2/cascade-import [ Skip ]

These above web platform tests for the specs
  https://drafts.csswg.org/css-namespaces/
  https://drafts.csswg.org/css-conditional-3/
all pass when run locally on Linux.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d08665e8ffb8c55e0228f3b3400523aaf6ee949

commit 8d08665e8ffb8c55e0228f3b3400523aaf6ee949
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon Sep 11 04:17:07 2017

CSS: Import more CSS web platform tests

Import the CSS Namespaces and Conditional tests.

The tests will be disabled on the initial import.

Then we'll add OWNERS and only disable failing tests.

BUG= 763636 

Change-Id: I52cefe5c13c8cc5b773a9e0988808f0defbb2ec8
Reviewed-on: https://chromium-review.googlesource.com/658917
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500838}
[modify] https://crrev.com/8d08665e8ffb8c55e0228f3b3400523aaf6ee949/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/8d08665e8ffb8c55e0228f3b3400523aaf6ee949/third_party/WebKit/LayoutTests/W3CImportExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2bc45b4559ad65b3bb2227c1cc064f8b49b0aa

commit ad2bc45b4559ad65b3bb2227c1cc064f8b49b0aa
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Sep 12 03:06:38 2017

CSS: Enable WPT for CSS Namespaces, Conditional

The web platform tests for CSS Namespaces and
CSS Conditional are now enabled.

OWNERS have been added.

Bug:  763636 
Change-Id: I7fbead981bc2fd1706d0c8eda800e3c65ddb52cf
Reviewed-on: https://chromium-review.googlesource.com/662077
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501163}
[modify] https://crrev.com/ad2bc45b4559ad65b3bb2227c1cc064f8b49b0aa/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/ad2bc45b4559ad65b3bb2227c1cc064f8b49b0aa/third_party/WebKit/LayoutTests/external/wpt/css/css-conditional-3/OWNERS
[add] https://crrev.com/ad2bc45b4559ad65b3bb2227c1cc064f8b49b0aa/third_party/WebKit/LayoutTests/external/wpt/css/css-namespaces-3/OWNERS

Comment 3 by ericwilligers@chromium.org, Sep 12 2017

Status: Fixed (was: Started)
►

Sign in to add a comment