New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763634 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 566016
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Enabling Ask Google for Suggestions (AGfS) disables spellcheck

Reported by sits...@gmail.com, Sep 9 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36

Steps to reproduce the problem:
1. Go to chrome://settings/?search=spelling+errors and ensure Use a web service to help resolve is toggled to off.
2. Go to a page (such as https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_form_submit ) with a text box and type "hjhk ".
3. Press the right mouse button over hjhk and select "Ask Google for Suggestions".
4. Click enable.

Do the either of the following:
5a. Click to the right of hjhk and type "hjhk " again.

5b. Do a page refresh (e.g. ⌘ + R).
6b. type "hjhk " into a text box again.

What is the expected behavior?
hjhk to be underlined in red.

What went wrong?
hjhk is not underlined in red.

Did this work before? Yes Chrome 59?

Chrome version: 61.0.3163.79  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Might be linked to  Issue 727172  (but that issue has been verified as fixed).

If you have hjhk underlined in other tabs that were open prior to enabling AGfS they may or may not continue to underline the hjhk misspelling (see screenshot for an example).
 

Comment 1 by sits...@gmail.com, Sep 9 2017

eratic_spellcheck.png
19.5 KB View Download
Labels: Needs-Triage-M61
Cc: krajshree@chromium.org
Components: UI>Browser>Language>Spellcheck
Labels: Needs-Feedback
Unable to reproduce the issue in MacBook Pro (Retina, 15-inch, Mid 2014), 10.12.6 and Win-10 using chrome reported version #61.0.3163.79 and latest canary #63.0.3213.0.

Following are the steps followed to reproduce the issue.
------------
1. Navigated to chrome://settings/?search=spelling+errors and ensured "Use a web service to help resolve" is toggled to off.
2. Navigated to URL: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_form_submit and typed "hjhk ".
3. Pressed the right mouse button over hjhk and selected "Ask Google for Suggestions".
4. Clicked enable.
5. Clicked to the right of hjhk and typed "hjhk " again.
6. Observed that hjhk was underlined in red as expected.

Note: There were no hjhk underlined in others tabs.

Attaching screen cast for reference.

sitsofe@ - Could you please check this issue on latest canary #63.0.3213.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not.

Thanks...!!
Attaching screencast
763634.mp4
1.5 MB View Download

Comment 5 by sits...@gmail.com, Sep 13 2017

Just reproduced with the following and a fresh profile:
Google Chrome	63.0.3214.0 (Official Build) canary (64-bit)
Revision	21dea15ba6117af0b06bd89c6dd6f427a016423d-refs/heads/master@{#501490}
OS	Mac OS X

/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir=/tmp/chromedatadir/ 

Comment 6 by sits...@gmail.com, Sep 13 2017

Also notice how in the screencast the person typing fails to type a space after hjhk which would have triggered the red underline.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 Deleted

Comment 9 by sits...@gmail.com, Sep 13 2017

Note the command run that I stated was old, it should have been: /Volumes/Google\ Chrome\ Canary/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --user-data-dir=/tmp/chromedatadir/ 

Components: -UI>Browser>Language>Spellcheck Blink>Editing>Spellcheck
Seems like a blink issue.

Comment 11 by sits...@gmail.com, Sep 13 2017

Has anyone managed to successfully reproduce this issue?
Thank you I will do that and I appreciate your responses I didn't realise
that I actually had star added to it again THANK YOU....

Comment 13 by yosin@chromium.org, Sep 19 2017

Cc: yosin@chromium.org
Components: -Blink>Editing>Spellcheck UI>Browser>Language>Spellcheck
Labels: OS-Windows
Owner: rouslan@chromium.org
Status: Untriaged (was: Unconfirmed)
Route to UI>Browser>Language>Spellcheck, since this may be spell checking web service
issue instead of Blink.

I could not reproduce this issue. However, latency of appearing red waveline is long.

rouslan@, can we have metrics of latency, # of clients, etc of spell checking
web service?

Cc: groby@chromium.org
Labels: -Pri-2 Pri-3
Mergedinto: 566016
Status: Duplicate (was: Untriaged)
"Ask Google for Suggestions" does not deal well with gibberish (hjhk). In addition, the feature does not do well without any context, because it's a contextual spelling checker. If Google cannot figure out what you meant to write, it will not suggest any spell corrections and will not underline your word as misspelled. This is a tradeoff between underlining everything that spellcheck has  seen rare (hjhk) and being more relaxed when new terms appear in the world (skrillex). If you Googke hjhk, you will see several legitimate uses in such contexts as youtube video tags or game nicks. Not sure what's the best course of action here.

Comment 15 by sits...@gmail.com, Sep 19 2017

@rouslan: phew! I'm sure I originally saw this problem with something other than gibberish but I can't for the life of me remember what the context was but thanks for the explanation. I'll respond further on the original issue.

Sign in to add a comment