New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763630 link

Starred by 5 users
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
█ lgar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Reenable Warnings link scrolls out of view on Mac

Project Member Reported by elawrence@chromium.org, Sep 9 2017 
Chrome Version: 61.3163
OS: 10.12.6

What steps will reproduce the problem?
(1) Visit https://www.iad.gov
(2) Type "abadidea" to bypass intersitial
(3) Open Page Info while the page is loading

OBSERVE: "Re-enable warnings" link appears and scrolls out of PageInfo viewport.

(Note: Doesn't seem to repro in Chrome 63 with MacViews turned on)
Screen Shot 2017-09-08 at 10.53.46 PM.png
178 KB View Download

Comment 1 by lgar...@chromium.org, Sep 11 2017

Status: Available (was: Untriaged)
Woah, I love how it slowly sneaks over to the left in several steps!

The code adjusts the left margin of the button on every time the security section is laid out: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm?type=cs&q=IDS_PAGE_INFO_RESET_INVALID_CERTIFICATE_DECISIONS_BUTTON&sq=package:chromium&l=673

Appears that this kind of page load triggers the layout repeatedly.

The fix is probably to calculate the horizontal position using `helpOrigin`.

Comment 2 by lgar...@chromium.org, Sep 12 2017

Labels: Hotlist-Polish Hotlist-GoodFirstBug

Comment 4 by claudiom...@gmail.com, Sep 16 2017 

Screenshot after the code changes, including in RTL mode.
Screen Shot 2017-09-16 at 04.28.47.png
149 KB View Download
Screen Shot 2017-09-16 at 04.29.30.png
172 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1448661059f13404f3e45e630816a5d83972ce52

commit 1448661059f13404f3e45e630816a5d83972ce52
Author: Claudio DeSouza <claudiomdsjr@gmail.com>
Date: Wed Sep 20 18:48:40 2017

Fixed Reenable Warnings moving incrementally at each view update on Mac.

R=avi@chromium.org

Bug:  763630 
Change-Id: I83708ff2f305313b4e8a16c7c2b76ee6d9ade382
Reviewed-on: https://chromium-review.googlesource.com/668538
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503215}
[modify] https://crrev.com/1448661059f13404f3e45e630816a5d83972ce52/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm

Comment 6 by lgar...@chromium.org, Sep 20 2017

Labels: M-63
Status: Fixed (was: Available)

Comment 7 by patricia...@chromium.org, Nov 15 2017 

Issue 782387 has been merged into this issue.
►

Sign in to add a comment