New issue
Advanced search Search tips

Issue 763610 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

WPT: Import and enable tests for CSS Cascade

Project Member Reported by ericwilligers@chromium.org, Sep 9 2017

Issue description

The following tests are currently skipped during WPT imports:
external/wpt/css/CSS2/cascade [ Skip ]
external/wpt/css/CSS2/cascade-import [ Skip ]
external/wpt/css/css-cascade-3 [ Skip ]
external/wpt/css/css-cascade-4 [ Skip ]

When I run them locally on Linux, the following fail:
external/wpt/css/CSS2/cascade/inherit-computed-001.html
external/wpt/css/css-cascade-4/revert-val-001.html


Also, the single test in 
wpt/css-cascade
should move to
wpt/css/css-cascade-3

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da28029cf4834daf7e194c267786706e3ed612de

commit da28029cf4834daf7e194c267786706e3ed612de
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon Sep 11 08:00:16 2017

CSS: Import CSS Cascade web platform tests

The tests will be disabled on the initial import.

Then we'll add OWNERS and only disable failing tests.

BUG=763610

Change-Id: Ice73f118ffacfe8bc405217d7105926122d54df9
Reviewed-on: https://chromium-review.googlesource.com/658199
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500857}
[modify] https://crrev.com/da28029cf4834daf7e194c267786706e3ed612de/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/da28029cf4834daf7e194c267786706e3ed612de/third_party/WebKit/LayoutTests/W3CImportExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70772ae7f82dd7fac8a3e67280962624a97e2edc

commit 70772ae7f82dd7fac8a3e67280962624a97e2edc
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Sep 12 09:06:19 2017

WPT: Enable tests for CSS Cascade

The following tests are no longer skipped:
external/wpt/css/CSS2/cascade-import
external/wpt/css/css-cascade-3
external/wpt/css/css-cascade-4

BUG=763610

Change-Id: I5d4b0f806d9deb160e4075d17754ea5729eae535
Reviewed-on: https://chromium-review.googlesource.com/662484
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501221}
[modify] https://crrev.com/70772ae7f82dd7fac8a3e67280962624a97e2edc/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/70772ae7f82dd7fac8a3e67280962624a97e2edc/third_party/WebKit/LayoutTests/external/wpt/css/css-cascade-3/OWNERS
[add] https://crrev.com/70772ae7f82dd7fac8a3e67280962624a97e2edc/third_party/WebKit/LayoutTests/external/wpt/css/css-cascade-4/OWNERS

Labels: -Update-Monthly Update-Quarterly
Owner: ----
Status: Available (was: Started)
All but the external/wpt/css/CSS2/cascade tests have been enabled.

These tests fail with missing *-expected.txt errors.

Comment 4 by nainar@chromium.org, Nov 30 2017

Labels: -Type-Bug Type-Task
Labels: -Update-Quarterly
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
https://crbug.com/579788
external/wpt/css/css-cascade/revert-val-001.html fails as we don't support revert

https://crbug.com/552085
external/wpt/css/css-cascade/important-prop.html fails as !important rules don't override animations.

We don't run external/wpt/css/CSS2/cascade [ WontFix ]

We may never run the user-stylesheet tests. For the others in CSS2/cascade, we could check that there are equivalent tests we do run, and close this issue as WontFix.
Status: Available (was: Untriaged)

Sign in to add a comment