Reenable testNetworkConnection test for device_check_egtest when Wifi tests running |
|||||
Issue descriptionCurrently we decided to disable the network checker test 'testNetworkConnection' in device_check_egtest due to wifi issue, see bug https://bugs.chromium.org/p/chromium/issues/detail?id=763581 In the future if there are iOS tests with network connection running, need to re-enable testNetworkConnection test in device_check_egtest, to avoid the wifi flake source.
,
Nov 28 2017
Based on @sergeyberezin, we are beginning to run external URL tests again, and the A-lab now has wi-fi, so we should re-enable the wi-fi check.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30ff548ccb973752c09c345fc773ef8ab9d01ddf commit 30ff548ccb973752c09c345fc773ef8ab9d01ddf Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Tue Nov 28 22:24:50 2017 [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm Since we are beginning to run external URL test again, and labs now has wifi. We need to re-enable the wifi checker test for swarming_cron use. Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab Reviewed-on: https://chromium-review.googlesource.com/794341 Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519867} [modify] https://crrev.com/30ff548ccb973752c09c345fc773ef8ab9d01ddf/ios/chrome/test/earl_grey/device_check_egtest.mm
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17810546dc4ca5692af2060225cd6ad1eae1ca34 commit 17810546dc4ca5692af2060225cd6ad1eae1ca34 Author: Sergey Berezin <sergeyberezin@chromium.org> Date: Wed Nov 29 18:25:04 2017 Revert "[iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm" This reverts commit 30ff548ccb973752c09c345fc773ef8ab9d01ddf. Reason for revert: A-lab devices still have no internet connectivity, causing them to become "unavailable". Original change's description: > [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm > > Since we are beginning to run external URL test again, and labs now has > wifi. We need to re-enable the wifi checker test for swarming_cron use. > > Bug: 763582 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab > Reviewed-on: https://chromium-review.googlesource.com/794341 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519867} TBR=sergeyberezin@chromium.org,baxley@chromium.org,liaoyuke@chromium.org,huangml@chromium.org,shenghuazhang@chromium.org Change-Id: I13642410635d4abf7cc91d3539d6a06236317370 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/797490 Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520169} [modify] https://crrev.com/17810546dc4ca5692af2060225cd6ad1eae1ca34/ios/chrome/test/earl_grey/device_check_egtest.mm
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c40391fcc5347d26d9b54be672052f8796b4c31 commit 6c40391fcc5347d26d9b54be672052f8796b4c31 Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Tue Dec 05 19:41:16 2017 Reland "[iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm" This is a reland of 30ff548ccb973752c09c345fc773ef8ab9d01ddf Original change's description: > [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm > > Since we are beginning to run external URL test again, and labs now has > wifi. We need to re-enable the wifi checker test for swarming_cron use. > > Bug: 763582 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab > Reviewed-on: https://chromium-review.googlesource.com/794341 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519867} Bug: 763582 Change-Id: I2bdf2a0903cf2f6c7307341f8570f80abf394ea5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/809406 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521789} [modify] https://crrev.com/6c40391fcc5347d26d9b54be672052f8796b4c31/ios/chrome/test/earl_grey/device_check_egtest.mm
,
Dec 22 2017
,
Dec 22 2017
Moved all Infra>Client>iOS bugs to Infra>Client>Chrome + OS-iOS.
,
Jun 13 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkl@chromium.org
, Sep 11 2017