New issue
Advanced search Search tips

Issue 763573 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 781686



Sign in to add a comment

[Intervention] Stop loading in the background on Android (after 5 mins)

Project Member Reported by panicker@chromium.org, Sep 8 2017

Issue description

Similar to how we stop timer tasks in background on Android after 5 mins, we should look at stopping loading next.

Based on UMA:
- among task types consuming CPU after 5mins in background, loading task queue is the big culprit (~38%)
https://uma.googleplex.com/p/chrome/histograms?endDate=20170907&dayCount=7&histograms=RendererScheduler.TaskDurationPerQueueType2.Background.AfterFifthMinute&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

This is only the CPU involved in responding to network fetches, in addition making resource requests consumes additional resources (CPU and data)


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39707c16e37d03a3e3ae79d297172fdaf68f4c7

commit c39707c16e37d03a3e3ae79d297172fdaf68f4c7
Author: Shubhie Panicker <panicker@chromium.org>
Date: Sat Oct 07 00:02:10 2017

Plumb stop loading signal to ResourceLoadScheduler.
Depends on CL https://chromium-review.googlesource.com/c/chromium/src/+/653493

Bug:  763573 
Change-Id: I776d325668e128756910d50e7d1146f2557e4529
Reviewed-on: https://chromium-review.googlesource.com/667449
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507236}
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/c39707c16e37d03a3e3ae79d297172fdaf68f4c7/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h

Related CL (typo'd bug ID there):
https://chromium-review.googlesource.com/c/chromium/src/+/653493
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48616c3974cc51f34e2f8eeca462d4355f92e9d4

commit 48616c3974cc51f34e2f8eeca462d4355f92e9d4
Author: Shubhie Panicker <panicker@chromium.org>
Date: Thu Oct 26 21:46:25 2017

Add finch flag for stop loading in background.

Bug:  763573 
Change-Id: I590c0c8abe4b07622ae68f5707c9856acaef0747
Reviewed-on: https://chromium-review.googlesource.com/734165
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511972}
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/chrome/browser/about_flags.cc
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/content/child/runtime_features.cc
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/content/public/common/content_features.cc
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/content/public/common/content_features.h
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/48616c3974cc51f34e2f8eeca462d4355f92e9d4/tools/metrics/histograms/enums.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ffd6254a28dc68a0678eaeadcccee2e1b8b560d

commit 9ffd6254a28dc68a0678eaeadcccee2e1b8b560d
Author: Shubhie Panicker <panicker@chromium.org>
Date: Tue Oct 31 00:28:16 2017

Decouple Stopped in bg signal from stop loading experiment.

Make triggering of Stopped in bg signal more generic, it should not be
tied to the experiment to stop loading.
A future CL will trigger a JS callback to indicate stopped to the app. 

Bug:  763573 
Change-Id: I439e70fab824d2e243ebfa731d5f27464dc629ff
Reviewed-on: https://chromium-review.googlesource.com/736903
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512690}
[modify] https://crrev.com/9ffd6254a28dc68a0678eaeadcccee2e1b8b560d/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/9ffd6254a28dc68a0678eaeadcccee2e1b8b560d/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874b898797b8bfade5da566d870841ab76b9094e

commit 874b898797b8bfade5da566d870841ab76b9094e
Author: Shubhie Panicker <panicker@chromium.org>
Date: Tue Nov 21 22:45:39 2017

Restrict StopLoadingInBackground flag to Android.

The flag was added in cl/734165, but did not restrict to Android,
we want to run the intervention only on Android.

Bug:  763573 
Change-Id: I180c32992ef4a36cec616e33d59b418305500265
Reviewed-on: https://chromium-review.googlesource.com/780691
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518422}
[modify] https://crrev.com/874b898797b8bfade5da566d870841ab76b9094e/chrome/browser/about_flags.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21d3ed45903d2547e1dff8e58d4b2cb491d4eee0

commit 21d3ed45903d2547e1dff8e58d4b2cb491d4eee0
Author: Shubhie Panicker <panicker@chromium.org>
Date: Wed Nov 22 00:06:13 2017

Enable StopLoadingInBackground experiment for field trial testing.

Bug:  763573 
Change-Id: I553d340be1aa5117f555544cc4b5e4151951a25c
Reviewed-on: https://chromium-review.googlesource.com/782643
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518468}
[modify] https://crrev.com/21d3ed45903d2547e1dff8e58d4b2cb491d4eee0/testing/variations/fieldtrial_testing_config.json

Blocking: 781686

Comment 8 by ojan@chromium.org, May 8 2018

Cc: -ojan@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16cff12f429ee1603ac0094505d8b41f7a58ee87

commit 16cff12f429ee1603ac0094505d8b41f7a58ee87
Author: Scott Haseley <shaseley@google.com>
Date: Thu May 31 23:15:53 2018

Allow stop-loading-in-background finch flag for all OSes

Enabling this on desktop is helpful for local task queue freezing testing on
desktop and prepares for upcoming finch trials on desktop.

Bug:  763573 
Change-Id: I9156a54d73c4a2b0ece01a47d8fdbedfca6978ee
Reviewed-on: https://chromium-review.googlesource.com/1081185
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#563422}
[modify] https://crrev.com/16cff12f429ee1603ac0094505d8b41f7a58ee87/chrome/browser/about_flags.cc

Status: Fixed (was: Assigned)

Sign in to add a comment