Bug: Lock screen apps are enabled in kiosk mode. |
||||||||||
Issue descriptionHere LockScreenApps profile is initialized in kiosk session: [9276:9276:0908/161032.560074:ERROR:preferences.cc(363)] Preferences::RegisterProfilePrefs(): Registering kUserTimezone with value 'America/Los_Angeles' in 0x2fca18817c80 at: #0 0x7f995ebd8fcd base::debug::StackTrace::StackTrace() #1 0x7f995ebd7a3c base::debug::StackTrace::StackTrace() #2 0x7f995c7359dc chromeos::Preferences::RegisterProfilePrefs() #3 0x7f995e818fbe chrome::RegisterProfilePrefs() #4 0x7f995e819395 chrome::RegisterUserProfilePrefs() #5 0x7f995e8334cd ProfileImpl::ProfileImpl() #6 0x7f995e8316d4 Profile::CreateProfile() #7 0x7f995e199fb8 ProfileManager::CreateProfileAsyncHelper() #8 0x7f995e192372 ProfileManager::CreateProfileAsync() #9 0x7f995c3b49f9 lock_screen_apps::StateController::SetPrimaryProfile() #10 0x7f995c492335 chromeos::UserSessionManager::FinalizePrepareProfile() #11 0x7f995c491db3 chromeos::UserSessionManager::UserProfileInitialized() #12 0x7f995c49113e chromeos::UserSessionManager::OnProfileCreated() #13 0x7f995c49df96 _ZN4base8internal13FunctorTraitsIMN8chromeos18UserSessionManagerEFvRKNS2_11UserContextEbP7ProfileNS7_12CreateStatusEEvE6InvokeIRKNS_7WeakPtrIS3_EEJS6_RKbS8_S9_EEEvS #14 0x7f995c49de62 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN8chromeos18UserSessionManagerEFvRKNS4_11UserContextEbP7ProfileNS9_12CreateStatusEERKNS_7WeakPtrIS5_EEJS8_RKbSA_S #15 0x7f995c49dd8e _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos18UserSessionManagerEFvRKNS3_11UserContextEbP7ProfileNS8_12CreateStatusEEJNS_7WeakPtrIS4_EES5_bEEEFvS9_SA_EE7Run #16 0x7f995c49dc3e _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos18UserSessionManagerEFvRKNS3_11UserContextEbP7ProfileNS8_12CreateStatusEEJNS_7WeakPtrIS4_EES5_bEEEFvS9_SA_EE3Run #17 0x7f9959fa22b0 _ZNKR4base17RepeatingCallbackIFvPN7content12DownloadItemENS1_23DownloadInterruptReasonEEE3RunES3_S4_ #18 0x7f995e1985bc ProfileManager::RunCallbacks() #19 0x7f995e198490 ProfileManager::OnProfileCreated() #20 0x7f995e834e5f ProfileImpl::DoFinalInit() #21 0x7f995e836c9a ProfileImpl::OnLocaleReady()
,
Sep 12 2017
,
Sep 12 2017
Consider this merge approved for 62, but please ensure a build of Chrome with this change makes it through the PFQ on ToT first, as the branch builders have no PFQ protection. 61 merge can be reviewed after 62 is proven to be ok.
,
Sep 12 2017
sounds good
,
Sep 12 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
Approving merge to M61.
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d776792ba047ae3494f309e15597bcaf86c397cd commit d776792ba047ae3494f309e15597bcaf86c397cd Author: Toni Barzic <tbarzic@google.com> Date: Sat Sep 16 00:46:37 2017 Skip lock screen apps initialization for non gaia users Lock screen apps are available only for gaia users, so there is no need for lock screen apps initialization for other users (and no need to create lock screen apps profile). BUG= 763572 TBR=tbarzic@google.com (cherry picked from commit dab8eb755ad166c8330e40542ea9792cf5eddd08) Change-Id: I01ad311e9c5bac4be87921d4871758fdd4718abb Reviewed-on: https://chromium-review.googlesource.com/660880 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501003} Reviewed-on: https://chromium-review.googlesource.com/669693 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#272} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/d776792ba047ae3494f309e15597bcaf86c397cd/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/d776792ba047ae3494f309e15597bcaf86c397cd/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc5864c3b600ebd6458aa9a0c6308a111e8d9d0 commit 5bc5864c3b600ebd6458aa9a0c6308a111e8d9d0 Author: Toni Barzic <tbarzic@google.com> Date: Sat Sep 16 01:23:43 2017 Skip lock screen apps initialization for non gaia users Lock screen apps are available only for gaia users, so there is no need for lock screen apps initialization for other users (and no need to create lock screen apps profile). BUG= 763572 TBR=tbarzic@google.com (cherry picked from commit dab8eb755ad166c8330e40542ea9792cf5eddd08) Change-Id: I01ad311e9c5bac4be87921d4871758fdd4718abb Reviewed-on: https://chromium-review.googlesource.com/660880 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501003} Reviewed-on: https://chromium-review.googlesource.com/669694 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1214} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5bc5864c3b600ebd6458aa9a0c6308a111e8d9d0/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/5bc5864c3b600ebd6458aa9a0c6308a111e8d9d0/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
,
Sep 16 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 11 2017