New issue
Advanced search Search tips

Issue 763564 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature
Launch-Accessibility: NA
Launch-Exp-Leadership: NA
Launch-Leadership: NA
Launch-Legal: NA
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: Finch



Sign in to add a comment

Native Extension Bindings

Project Member Reported by rdevlin....@chromium.org, Sep 8 2017

Issue description

Technical feature description:
Rewrite extension bindings natively in C++ using v8 and gin libraries.

Eng owner: rdcronin@

Design doc (send to chrome-design-docs@): https://docs.google.com/document/d/15RKF7kfVcsdZtg1fkQiQX0pOzoN0u18mT-Cglq1ThPk/edit#

Metrics:
Extensions.DidCreateScriptContext_BlessedWebPage,
Extensions.DidCreateScriptContext_LockScreenExtension,
Extensions.DidCreateScriptContext_Unblessed,
Extensions.DidCreateScriptContext_WebPage,
Extensions.DidCreateScriptContext_ContentScript,
Extensions.DidCreateScriptContext_Blessed,
Extensions.DidCreateScriptContext_Unspecified,
Extensions.DidCreateScriptContext_WebUI,

Extensions.Bindings.UpdateBindingsForContextTime.LockScreenExtensionContext,
Extensions.Bindings.UpdateBindingsForContextTime.ContentScriptContext,
Extensions.Bindings.UpdateBindingsForContextTime.BlessedWebPageContext,
Extensions.Bindings.UpdateBindingsForContextTime.WebPageContext,
Extensions.Bindings.UpdateBindingsForContextTime.ServiceWorkerContext,
Extensions.Bindings.UpdateBindingsForContextTime.UnblessedExtensionContext,
Extensions.Bindings.UpdateBindingsForContextTime.BlessedExtensionContext,
Extensions.Bindings.UpdateBindingsForContextTime.WebUIContext,

Extensions.Bindings.NativeBindingCreationTime, 
Extensions.ApiBindingGenerationTime,
 
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Description: Show this description
Cc: lazyboy@chromium.org jawag@chromium.org jbroman@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 11 2017

This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 12 2018

This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by amin...@google.com, May 16 2018

Labels: Launch-Exp-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Exp-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.

Comment 7 by amin...@google.com, May 16 2018

Labels: Launch-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef734f4659e2af652b6846e073be226cd11de6d

commit 0ef734f4659e2af652b6846e073be226cd11de6d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jun 21 15:53:50 2018

[Extensions Bindings] Add a fieldtrial testing config entry for native bindings

We're getting ready to roll extension bindings out to beta, so add a
fieldtrial testing config entry for the experiment to have it run by
default on the bots.

Bug: 763564

Change-Id: Ibdf83e16cbc10e4c62e2304cf14cd7c24377bc31
Reviewed-on: https://chromium-review.googlesource.com/1108192
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569277}
[modify] https://crrev.com/0ef734f4659e2af652b6846e073be226cd11de6d/chrome/browser/extensions/error_console/error_console_browsertest.cc
[modify] https://crrev.com/0ef734f4659e2af652b6846e073be226cd11de6d/testing/variations/fieldtrial_testing_config.json

Labels: Launch-M-Target-68-Dev Launch-M-Target-68-Beta Launch-M-Target-69-Dev Launch-M-Target-69-Beta Launch-M-Target-70-Dev Launch-M-Target-70-Beta Rollout-Type-Finch
Adding mstones.  This has been in dev/canary for quite awhile, and we're expanding to beta soon.  Since this is a simple launch, my understanding is that no further approvals are necessary.
Labels: -Type-Launch -Launch-M-Target-68-Dev -Launch-M-Target-68-Beta -Launch-M-Target-69-Dev -Launch-M-Target-69-Beta -Launch-M-Target-70-Dev -Launch-M-Target-70-Beta Type-Feature
Note: This no longer requires launch review under the new policies (since it is not user facing, and is just a technical refactoring).  Finch complains about not having approvals, so we need to either change this bug type or file a new one.  Let's see how the former goes...
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment