New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763563 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Autoconf isn't working for zeroconf printers from settings

Project Member Reported by skau@chromium.org, Sep 8 2017

Issue description

Chrome Version: 61.3163.75
OS: CrOS

What steps will reproduce the problem?
(1) Add a printer to your network that we don't have a PPD for but can be setup using autoconf
(2) Hook said printer up to your network
(3) Open Chromebook printing settings
(4) Choose 'ADD PRINTER'
(5) See printer in "Nearby"
(6) Choose Printer

What is the expected result?
We detect printer configuration and set it up automatically

What happens instead?
User asked to choose their Make and Model


What else could cause this problem?
Turning off the printer.  The printer doesn't actually support autoconf.

How do you know this is the correct problem?
IPP queries are failing when we do detection.  It's not logged (right now) but I just know.
 

Comment 1 by skau@chromium.org, Sep 11 2017

We're not checking if it's autoconf at all.  I'll add that step to the setup flow.

Comment 2 by skau@chromium.org, Sep 11 2017

TODO: Move querying to PrinterConfigurer with an option to detect it.

Comment 3 by skau@chromium.org, Sep 13 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea4450501c393c478fe3b428071a7eb909124ea

commit 3ea4450501c393c478fe3b428071a7eb909124ea
Author: Sean Kau <skau@chromium.org>
Date: Wed Sep 20 19:41:40 2017

Run autoconf checks for discovered printers.

If we discover a printer, we want to check if it's capable of autoconf
if we don't have a PPD.  This should cover a number of printers that
one expects to be configurable where it does not work currently.

Bug:  763563 
Change-Id: I46ab2f69f8777a97a04296b6e29754b4cd03b042
Reviewed-on: https://chromium-review.googlesource.com/664183
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503228}
[modify] https://crrev.com/3ea4450501c393c478fe3b428071a7eb909124ea/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/3ea4450501c393c478fe3b428071a7eb909124ea/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Comment 5 by skau@chromium.org, Sep 21 2017

Status: Fixed (was: Started)

Comment 6 by skau@chromium.org, Sep 25 2017

Labels: Merge-Request-62
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 25 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by skau@chromium.org, Sep 25 2017

Verified to work on hana in canary 63.0.3223.0

Comment 9 by skau@chromium.org, Sep 25 2017

Labels: Merge-Request-61

Comment 10 by skau@chromium.org, Sep 25 2017

Bug also shows up in M61 for new printer setup method.  Users could have a bad first experience if we don't pick back to M61.
Labels: -Merge-Review-62 Merge-Approved-62
Approved for 62. 
Labels: -Hotlist-Merge-Review -Merge-Request-61 Merge-Approved-61
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 25 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cf5adab08abe1f4cb8dbf83f41a896d736aa81

commit d8cf5adab08abe1f4cb8dbf83f41a896d736aa81
Author: Sean Kau <skau@chromium.org>
Date: Mon Sep 25 20:29:49 2017

Run autoconf checks for discovered printers.

If we discover a printer, we want to check if it's capable of autoconf
if we don't have a PPD.  This should cover a number of printers that
one expects to be configurable where it does not work currently.

Bug:  763563 
Change-Id: I46ab2f69f8777a97a04296b6e29754b4cd03b042
Reviewed-on: https://chromium-review.googlesource.com/664183
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503228}(cherry picked from commit 3ea4450501c393c478fe3b428071a7eb909124ea)
Reviewed-on: https://chromium-review.googlesource.com/682555
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#436}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d8cf5adab08abe1f4cb8dbf83f41a896d736aa81/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/d8cf5adab08abe1f4cb8dbf83f41a896d736aa81/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11e91b65961c01213c02edc80537b4c01d2aaa47

commit 11e91b65961c01213c02edc80537b4c01d2aaa47
Author: Sean Kau <skau@chromium.org>
Date: Mon Sep 25 20:32:17 2017

Run autoconf checks for discovered printers.

If we discover a printer, we want to check if it's capable of autoconf
if we don't have a PPD.  This should cover a number of printers that
one expects to be configurable where it does not work currently.

Bug:  763563 
Change-Id: I46ab2f69f8777a97a04296b6e29754b4cd03b042
Reviewed-on: https://chromium-review.googlesource.com/664183
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503228}(cherry picked from commit 3ea4450501c393c478fe3b428071a7eb909124ea)
Reviewed-on: https://chromium-review.googlesource.com/682556
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1278}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/11e91b65961c01213c02edc80537b4c01d2aaa47/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/11e91b65961c01213c02edc80537b4c01d2aaa47/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Comment 15 by skau@chromium.org, Sep 26 2017

Fix slated for release:
$ git find-releases 3ea4450
commit 3ea4450 was:
  initially in 63.0.3221.0
  merged to 61.0.3163.106 (as 11e91b65961c01213c02edc80537b4c01d2aaa47)
  merged to 62.0.3202.35 (as d8cf5adab08abe1f4cb8dbf83f41a896d736aa81)


Sign in to add a comment