Issue metadata
Sign in to add a comment
|
click inside disambiguation UI is not working |
||||||||||||||||||||
Issue descriptionThis affects Chrome Dev (M62) and Canary (M63), not Chrome Beta (M61). Load a desktop site like google.com/finance. Try to tap a stock symbol, expect the disambiguation UI pops up. Taps inside disambiguation UI. Expect: navigation. Observed: disambiguation UI dismissed. Nothing happens.
,
Sep 10 2017
Thanks for the report & bisect. On it now.
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa2555e0238d9037c616387e3754bced50a906e8 commit aa2555e0238d9037c616387e3754bced50a906e8 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Mon Sep 11 22:35:08 2017 Fix a bug in disambiguation popup The reported bug was caused by http://crrev.com/497292 that refactors the popup zoomer used for tap disambiguation. This CL fixes it by scaling the touch event coordinate correctly before sending it to Blink. Bug: 763553 Change-Id: Ib0ab717daaf21018ed16c88a5fb3b69a768156a6 Reviewed-on: https://chromium-review.googlesource.com/658203 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501069} [modify] https://crrev.com/aa2555e0238d9037c616387e3754bced50a906e8/content/browser/android/popup_zoomer.cc
,
Sep 11 2017
,
Sep 12 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a20a7a5db5936d6c10a02680377f6fe2d89ce82 commit 6a20a7a5db5936d6c10a02680377f6fe2d89ce82 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Tue Sep 12 23:58:08 2017 Fix a bug in disambiguation popup The reported bug was caused by http://crrev.com/497292 that refactors the popup zoomer used for tap disambiguation. This CL fixes it by scaling the touch event coordinate correctly before sending it to Blink. Bug: 763553 Change-Id: Ib0ab717daaf21018ed16c88a5fb3b69a768156a6 Reviewed-on: https://chromium-review.googlesource.com/658203 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501069}(cherry picked from commit aa2555e0238d9037c616387e3754bced50a906e8) Reviewed-on: https://chromium-review.googlesource.com/664317 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#188} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/6a20a7a5db5936d6c10a02680377f6fe2d89ce82/content/browser/android/popup_zoomer.cc
,
Sep 13 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by aelias@chromium.org
, Sep 8 2017Labels: -Type-Bug ReleaseBlock-Stable M-62 Type-Bug-Regression
Owner: jinsuk...@chromium.org