New issue
Advanced search Search tips

Issue 763550 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Flaky Test: BaseAudioContextAutoplayTest/BaseAudioContextAutoplayTest

Project Member Reported by hongchan@chromium.org, Sep 8 2017

Issue description

Issue 752511 has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580e219d7c22de10827c1a11fef0ad164db0d7ab

commit 580e219d7c22de10827c1a11fef0ad164db0d7ab
Author: Hongchan Choi <hongchan@chromium.org>
Date: Tue Sep 12 23:54:35 2017

Disabling BaseAudioContextAutoplayTest on all platforms

The test has been flaky and we could not reproduce the time-out locally.
To suppress the warning/error, we should disable the test until
we figure out the solution.

Bug:  763550 
Change-Id: Ia89f569e372d0ee94860f2a1c0ace7d44cd5eb6f
Reviewed-on: https://chromium-review.googlesource.com/664302
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501460}
[modify] https://crrev.com/580e219d7c22de10827c1a11fef0ad164db0d7ab/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp

Cc: hongchan@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358ce13c27c7e073254004e5f857543f6275b09d

commit 358ce13c27c7e073254004e5f857543f6275b09d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue May 22 20:16:57 2018

BaseAudioContextTest: attempt to fix disabled tests.

Re-enabling the tests as they pass locally and pass in dry run.
If they are still failing, it will allow to look at logs.

Is is removing the code specific to AudioWorklet thread as it was
breaking the tests and it is not needed.

Bug: 757759,  763550 
Change-Id: Iba36290f2c7b7b3a78313dad9cb60b373ede1d07
Reviewed-on: https://chromium-review.googlesource.com/757517
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560749}
[modify] https://crrev.com/358ce13c27c7e073254004e5f857543f6275b09d/third_party/blink/renderer/modules/webaudio/base_audio_context_test.cc

Status: Fixed (was: Started)

Sign in to add a comment