New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763545 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Pages improperly scaled in 2d browsing mode

Project Member Reported by vollick@chromium.org, Sep 8 2017

Issue description

Enter VR and notice the size of the page.

 
Labels: ReleaseBlock-Stable M-63
See also issue 763157, though that regressed in M62.
Cc: jinsuk...@chromium.org
Caused by https://chromium.googlesource.com/chromium/src/+/86071c86ba17eb7761cd0663bc95ceaaf3c4fb77?

looks like we used to call mTab.getContentViewCore().onSizeChanged(surfaceWidth, surfaceHeight, 0, 0), but on longer do in VRShellImpl.java

We do now call web_contents->GetNativeView()->OnSizeChanged(width, height); instead, but I'm not sure whether this updates all aspects of the size.


Owner: mthiesse@chromium.org
Michael, could you please take a look?
Cc: vollick@chromium.org
Status: Assigned (was: Started)
This also shows how important it is that we get pixel smoke tests that can catch this class of regression.
Cc: mthiesse@chromium.org
Owner: jinsuk...@chromium.org
Status: Started (was: Assigned)
That was a mistake - CVC.onSizeChanged() is still necessary. I'll fix it.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93edb8ef2b37b4157b5efd27f543b20c07af725e

commit 93edb8ef2b37b4157b5efd27f543b20c07af725e
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Sep 11 00:18:48 2017

Fix a bug scaling VR pages incorrectly

A call to CVC.onSizeChanged() got removed by mistake in
https://crrev.com/c/634847. This CL fixes it by putting
the call back in.

Bug:  763545 
TBR: mthiesse@chromium.org
Change-Id: Ieaa73a44d429d438d27f2b3ddaf4ac9d4c918948
Reviewed-on: https://chromium-review.googlesource.com/658924
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500819}
[modify] https://crrev.com/93edb8ef2b37b4157b5efd27f543b20c07af725e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: Fixed (was: Started)
Cc: ddorwin@chromium.org billorr@chromium.org
 Issue 763628  has been merged into this issue.
Status: Verified (was: Fixed)
verified in 63.0.3223.7

Sign in to add a comment