New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763534 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 831123

Blocking:
issue 770184



Sign in to add a comment

chrome not following autocomplete parameter

Reported by pe...@vaszari.com, Sep 8 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36

Steps to reproduce the problem:
1. goto: https://codepen.io/anon/pen/yomBZr/
2. fill the form
3. save username and password
4. goto: https://codepen.io/anon/pen/vJoBwJ/
5. click on 1st password field
6. Use Password for: select your previously saved one

What is the expected behavior?
Chrome should fill the hidden username field with autocomplete="username" parameter

What went wrong?
It fills the "search" input field

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 61.0.3163.79  Channel: stable
OS Version: 10.0
Flash Version: 

https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands

Search type should not filled:
https://bugs.chromium.org/p/chromium/issues/detail?id=468153
 
Labels: Needs-Triage-M61

Comment 2 by tkent@chromium.org, Sep 10 2017

Components: -Blink>Forms UI>Browser>Autofill

Comment 3 by ma...@chromium.org, Sep 11 2017

Components: UI>Browser>Passwords
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome reported version #61.0.3163.79 and latest canary #63.0.3213.3.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Navigated to: https://codepen.io/anon/pen/yomBZr/
2. filld the form
3. saved username and password
4. Navigated to: https://codepen.io/anon/pen/vJoBwJ/
5. clicked on 1st password field
6. Used Password for previously saved one.
7. Observed that chrome filled the hidden username field with autocomplete="username" parameter as expected.

peter@ - Could you please verify the screen cast and please let us know if anything missed from our side. If possible please provide a screen cast explaining the exact issue.

Thanks...!!
763534.mp4
1.0 MB View Download

Comment 5 by pe...@vaszari.com, Sep 13 2017

In the video you can see chrome filled the search field with autocomplete="off"
and ignored the hidden field with autocomplete="username" you reproduced the issue.
Capture.PNG
109 KB View Download
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by pe...@vaszari.com, Sep 13 2017

When you click on submit btn on 2nd page, you will see it is ignored the username field and put username into search field, if you remove search fields from the test  chrome put username into the hidden username field (how it should in all circumstances) If you need more detailed test, feel free to ask me.
Labels: OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Tested on reported Chrome #60.0.3112.90, latest stable #61.0.3163.91, Canary #63.0.3219.0 on Windows 10, Mac 10.12.6, Ubuntu 14.04 and able to reproduce the issue. 

This is a non-regression issue and able to reproduce from M-50 #50.0.2624.0. Marking it as untriaged so that issue gets addressed.

Attached screenshot for reference.

Thanks.

763534.PNG
115 KB View Download

Comment 9 by vabr@chromium.org, Oct 18 2017

Blocking: 770184
Cc: dvadym@chromium.org
Labels: -Pri-2 -Needs-Triage-M61 Hotlist-Polish OS-Chrome Pri-3
Status: Available (was: Untriaged)
Thanks for the report.

Indeed, looking at FindUsernameElementPrecedingPasswordElement in components/autofill/content/renderer/password_autofill_agent.cc, currently Chrome fails to take hidden autocomplete="username" fields into account when looking for fields to fill.

Vadym, what do you think of visibility overriding the autocomplete attribute, is that expected? If there is no text field at all, Chrome will happily fill just the password (which is the most important information to fill). So I would say. Chrome could accept the wish not to fill the username if it's expressed through autocomplete attributes (perhaps even by respecting the autocomplete=off on the visible field?)

Also, do you know why the current-password is not filled on load? Is that because Chrome only does it when the username field is also present and visible?

Comment 10 by pe...@vaszari.com, Oct 18 2017

Please consider my opinion: as a developer when I create the fields, I create them on purpose. If there is a hidden fields before password it can be anything, but when I add autocomplete="username" to the field I want to tell the browser that is the username field. It can be hidden or I can play with css to hide it etc... But it is not "accidentally" has autocomplete attribute.

So my point of view autocomplete should override the visibility.

Comment 11 by pe...@vaszari.com, Oct 18 2017

And one more thing:
If there is no other visible field in the form, Chrome find the hidden autocomplete="username" field and fill it with the username. Based on this behavior I think it should act the same way when other fields are in the form.
pe...@ In principle I agree with your arguments in comment 10. We need to discuss it in a team. For now you can move a search field outside <form> tag.

Comment 13 by pe...@vaszari.com, Jan 26 2018

dvadym@ I can't. It is ASP.NET Web Forms, everything in one big form. I know it is a bad practice, but that technology out there for 7 years.
Status: Untriaged (was: Available)
Blockedon: 831123
Status: Available (was: Untriaged)

Sign in to add a comment