This should make running and debugging tests more predictable. It's not what we want long term, but in the short term it should our lives easier.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aefd808a350f919fd976f1187bc1fedec1845241 commit aefd808a350f919fd976f1187bc1fedec1845241 Author: Scott Violet <sky@chromium.org> Date: Tue Sep 26 00:38:29 2017 chromeos: make catalog service directory requests on background thread The requests do file system access, which shouldn't run on the thread Catalog runs on (IO thread). BUG= 763529 TEST=none Change-Id: Ie5324370fde6ed8ad8206de40190b4a1c3bf5676 Reviewed-on: https://chromium-review.googlesource.com/682648 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#504236} [modify] https://crrev.com/aefd808a350f919fd976f1187bc1fedec1845241/content/public/test/test_launcher.cc [modify] https://crrev.com/aefd808a350f919fd976f1187bc1fedec1845241/services/catalog/catalog.cc [modify] https://crrev.com/aefd808a350f919fd976f1187bc1fedec1845241/services/catalog/catalog.h [modify] https://crrev.com/aefd808a350f919fd976f1187bc1fedec1845241/ui/views/mus/screen_mus_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee96ebe8be3e36bb1dbce64e6626bded3787e247 commit ee96ebe8be3e36bb1dbce64e6626bded3787e247 Author: Scott Violet <sky@chromium.org> Date: Tue Sep 26 23:53:21 2017 chromeos: Adds option for ash and mus to run standalone I'm changing --mash to run the ServiceManager in chrome. As part of this I'm making ash and mus launch in the same manner as other services are launched by chrome. That is, by the utility process. The utility process already does some setup these were doing that will not be necessary when launched via the utility process (registery paths), so this patch makes the registration configurable. BUG= 763529 TEST=none Change-Id: Ia00421caeeda66e4a7a0454fc25dc742f8a9be10 Reviewed-on: https://chromium-review.googlesource.com/685306 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504524} [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/ash/mus/main.cc [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/ash/mus/window_manager_application.cc [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/ash/mus/window_manager_application.h [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/services/ui/main.cc [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/services/ui/service.cc [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/services/ui/service.h [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/ui/views/mus/aura_init.cc [modify] https://crrev.com/ee96ebe8be3e36bb1dbce64e6626bded3787e247/ui/views/mus/aura_init.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649 commit 6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649 Author: Scott Violet <sky@chromium.org> Date: Wed Sep 27 16:45:33 2017 content: adds ability for configuring utility process for services Specifically: . Ability for the utility process's MessageLoop to be TYPE_UI. . Adds switch to identify when utility process is running a service. . Adds ability for ContentBrowserClient to adjust command line of process launched for services. I'll use this in Chrome to force utility process to use TYPE_UI message loop. BUG= 763529 TEST=none Change-Id: I7a0deadb9750d05f8ab7d15dbf8d433a51867a2c Reviewed-on: https://chromium-review.googlesource.com/685977 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504705} [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/browser/utility_process_host_impl.h [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/public/browser/content_browser_client.h [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/public/common/content_switches.cc [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/public/common/content_switches.h [modify] https://crrev.com/6ddaba276d3bd4ec8bc9035aedba65e7f2d6f649/content/utility/utility_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8 commit e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8 Author: Scott Violet <sky@chromium.org> Date: Wed Sep 27 23:14:03 2017 chromeos: adds run standalone for other apps used by mus+ash Doing this for same reason as patchset: https://chromium-review.googlesource.com/c/chromium/src/+/685306 BUG= 763529 TEST=none Change-Id: Ifb175f0ce95c04ad34ddfe49cb01765a4e2e30e9 Reviewed-on: https://chromium-review.googlesource.com/687888 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504794} [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/autoclick/mus/autoclick_application.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/autoclick/mus/autoclick_application.h [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/autoclick/mus/main.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/touch_hud/mus/main.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/touch_hud/mus/touch_hud_application.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/ash/touch_hud/mus/touch_hud_application.h [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/mash/quick_launch/main.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/mash/quick_launch/quick_launch.cc [modify] https://crrev.com/e9062983d2f3ee8a7dd86e32e6d1de95604f7bc8/mash/quick_launch/quick_launch.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/776edf8b268dfcd5feec8a3f0f295128e63e7ca4 commit 776edf8b268dfcd5feec8a3f0f295128e63e7ca4 Author: Scott Violet <sky@chromium.org> Date: Fri Sep 29 02:03:01 2017 chromeos: changes --mash to run ServiceManager in Chrome process Additionally all services that are launched run using the utility process. BUG= 763529 TEST=none Change-Id: I82ca2cef75335de7a85c7c7d3cb7362530a9ad56 Reviewed-on: https://chromium-review.googlesource.com/685979 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505252} [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/ash/autoclick/mus/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/ash/mus/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/ash/touch_hud/mus/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/chrome_main.cc [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/chrome_main_delegate.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/mash/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/app/mash/DEPS [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/app/mash/embedded_services.cc [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/app/mash/embedded_services.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/DEPS [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/chromeos/login/session/user_session_manager.cc [add] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/mash_service_registry.cc [add] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/mash_service_registry.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/ui/views/DEPS [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/common/chrome_switches.cc [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/common/chrome_switches.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/test/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/test/base/OWNERS [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/test/base/mash_browser_tests_main.cc [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/test/base/mash_browser_tests_manifest.json [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/test/base/mojo_test_connector.cc [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/test/base/mojo_test_connector.h [delete] https://crrev.com/ff9d46ff7d4406fcb3544a2eb5b14f14e896c1be/chrome/test/base/mus_browser_tests_manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/utility/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/utility/DEPS [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/utility/chrome_content_utility_client.cc [add] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/utility/mash_service_factory.cc [add] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/chrome/utility/mash_service_factory.h [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/components/font_service/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/components/font_service/public/interfaces/BUILD.gn [add] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/components/font_service/public/interfaces/constants.mojom [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/mash/quick_launch/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/mash/quick_launch/public/interfaces/BUILD.gn [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/services/ui/manifest.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/776edf8b268dfcd5feec8a3f0f295128e63e7ca4/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e1c16071b54b19082e5b777cc6591e3b4ce6ba commit d3e1c16071b54b19082e5b777cc6591e3b4ce6ba Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Oct 02 11:10:53 2017 Move the call to ::CreateQuickLaunch within OS_CHROMEOS guards This fixes the fyi.ozone/linux bot [1]. [1] https://build.chromium.org/p/chromium.fyi/builders/Ozone%20Linux TBR=sky@chromium.org BUG= 763529 Change-Id: I4709547797a87e2001861dcc50a53eb64b50a6b3 Reviewed-on: https://chromium-review.googlesource.com/695326 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#505576} [modify] https://crrev.com/d3e1c16071b54b19082e5b777cc6591e3b4ce6ba/chrome/utility/mash_service_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d66160822607fe290bed888dc511a8664f11d9e1 commit d66160822607fe290bed888dc511a8664f11d9e1 Author: Scott Violet <sky@chromium.org> Date: Thu Oct 05 16:33:05 2017 removes kIsService I never ended up needing it. BUG= 763529 TEST=none Change-Id: I4690f87c1979f58c966bd8a5e7cda606616e2320 Reviewed-on: https://chromium-review.googlesource.com/701834 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506756} [modify] https://crrev.com/d66160822607fe290bed888dc511a8664f11d9e1/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/d66160822607fe290bed888dc511a8664f11d9e1/content/public/common/content_switches.cc [modify] https://crrev.com/d66160822607fe290bed888dc511a8664f11d9e1/content/public/common/content_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6118c21e3c8bf1b90520aab787419a8484aa4f7 commit e6118c21e3c8bf1b90520aab787419a8484aa4f7 Author: Scott Violet <sky@chromium.org> Date: Thu Oct 05 16:34:35 2017 cleanup: remove functions no longer overriden in chrome BUG= 763529 TEST=none Change-Id: I24969570d882c546994a60d29d34a73366bce047 Reviewed-on: https://chromium-review.googlesource.com/701472 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506758} [modify] https://crrev.com/e6118c21e3c8bf1b90520aab787419a8484aa4f7/content/app/content_service_manager_main_delegate.cc [modify] https://crrev.com/e6118c21e3c8bf1b90520aab787419a8484aa4f7/content/public/app/content_main_delegate.cc [modify] https://crrev.com/e6118c21e3c8bf1b90520aab787419a8484aa4f7/content/public/app/content_main_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc commit 5ac0931d88e42ecc99b72d9ad0a28a6206378bcc Author: Scott Violet <sky@chromium.org> Date: Fri Oct 06 00:04:31 2017 cleanup build files around mash Removes build files and json files no longer needed. BUG= 763529 TEST=none Change-Id: I2926af9e461e1178ec63b0f0c1e1368d4dc26d51 Reviewed-on: https://chromium-review.googlesource.com/701258 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506924} [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/BUILD.gn [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/app/BUILD.gn [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/app/chrome_main_delegate.h [delete] https://crrev.com/783dc7b57549781f1ed08a5a946f5f5c5ebf224c/chrome/app/chrome_test_exe_main_aura.cc [delete] https://crrev.com/783dc7b57549781f1ed08a5a946f5f5c5ebf224c/chrome/app/mash/BUILD.gn [delete] https://crrev.com/783dc7b57549781f1ed08a5a946f5f5c5ebf224c/chrome/app/mash/DEPS [delete] https://crrev.com/783dc7b57549781f1ed08a5a946f5f5c5ebf224c/chrome/app/mash/OWNERS [delete] https://crrev.com/783dc7b57549781f1ed08a5a946f5f5c5ebf224c/chrome/app/mash/mash_service_overrides.json [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5ac0931d88e42ecc99b72d9ad0a28a6206378bcc/chrome/test/BUILD.gn
Bulk applying component Internals>Services>ServiceManager to issues referencing the text ServiceManager. This may not be 100% accurate, so please feel free to pull the component as needed.
I think this happened.
Comment 1 by sky@chromium.org
, Sep 8 2017