New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763499 link

Starred by 1 user
Status: Verified
Owner:
mahmadi@chromium.org
Closed: Sep 2017
Cc:
█ cma...@chromium.org
sdefresne@chromium.org
ma...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

iOS uses old credit card icons and the icons for "mir" network are missing

Project Member Reported by mahmadi@chromium.org, Sep 8 2017 
The icons bundled in imagesets in iOS are outdated and do not match those in components/resources/default_[100|200|300]_percent/autofill/.

Comment 1 by sdefresne@chromium.org, Sep 11 2017 

Maybe iOS should just be changed to use the resources from the component instead of having copies. This will require a little refactoring to not use UIImage -imageNamed: but instead to use ResourceBundle::GetNativeImageNamed().

Will have to change the method FormSuggestionLabel -imageNameForCreditCardIcon: to invoke GetPaymentRequestData(). Or remove the method altogether and put the code into FormSuggestion.

Once this is done, the imageset should be removed (to avoid having obsolete resources copied to the application bundle).
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d95a5c1bd393ebb4c7875810b73ca7167fd11f53

commit d95a5c1bd393ebb4c7875810b73ca7167fd11f53
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 12 14:33:23 2017

[Payment Request] Use a 16 pixel size for the favicon

Many websites use 16 pixel favicons. This CL avoids stretching the favicon
and results in a sharper image.

Bug:  763499 
Change-Id: I07208084990c22a05261bfce5d6d4b6c16fdfb8d
Reviewed-on: https://chromium-review.googlesource.com/663577
Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501268}
[modify] https://crrev.com/d95a5c1bd393ebb4c7875810b73ca7167fd11f53/ios/chrome/browser/ui/payments/cells/page_info_item.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfe1330e2c02792eab7821951263a2c0af3729b

commit 7cfe1330e2c02792eab7821951263a2c0af3729b
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 12 15:23:53 2017

[Autofill] Uses credit card icons in components instead of imagesets.

- Adds 3x resources to components/resources/autofill. These missing
  resources where causing the ResourceBundle to load the 1x ones for
  iPhone plus devices which resulted in blurry icons.
- Modifies the 1x and 2x resources for the generic credit card to match
  the 3x one.
- Removes the imagesets from iOS bundle and changes the autofill suggestion
  code to use the resources in the components.

Bug:  763499 
Change-Id: I5463bc20c30b884ee4685a3fd2cd28d84625a709
Reviewed-on: https://chromium-review.googlesource.com/660802
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501283}
[modify] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_100_percent/autofill/cc-generic.png
[modify] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_200_percent/autofill/cc-generic.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/amex.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/cc-generic.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/diners.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/discover.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/jcb.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/mastercard.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/mir.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/unionpay.png
[add] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/components/resources/default_300_percent/autofill/visa.png
[modify] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/ios/chrome/browser/autofill/form_suggestion_label.mm
[modify] https://crrev.com/7cfe1330e2c02792eab7821951263a2c0af3729b/ios/chrome/browser/autofill/resources/BUILD.gn
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/Contents.json
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x~ipad.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@3x.png
[delete] https://crrev.com/7bf1119d9136bffb7c5f44a11e532945494adca4/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa~ipad.png

Comment 4 by mahmadi@chromium.org, Sep 12 2017

Labels: merge-request
Status: Fixed (was: Started)

Comment 5 by mahmadi@chromium.org, Sep 12 2017

Labels: -Pri-3 -M-63 -merge-request Merge-Request-62 M-62 Pri-2

Comment 6 Deleted

Comment 7 Deleted

Comment 8 by cma...@chromium.org, Sep 13 2017 

I am seeing a lot of stuffs on payment request that need to be merged. Was this feature code complete by Feature freeze?
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a1ba1bfbbceaa4d591e0e4f19abc5aa0dccacdf

commit 1a1ba1bfbbceaa4d591e0e4f19abc5aa0dccacdf
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Sep 13 14:15:11 2017

[Autofill] Fixes a bug where all autofill suggestions have generic-cc icon

Bug:763499

after: https://drive.google.com/file/d/0B-GXJsF3pXyjRm4zbHVsaTFfSGs/view?usp=sharing
before: https://drive.google.com/file/d/0B-GXJsF3pXyjWUx5MG81QWFKNnM/view?usp=sharing

Change-Id: Iba3625cf83a626b38c4cf338650d0c98f06f674d
Reviewed-on: https://chromium-review.googlesource.com/664217
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501623}
[modify] https://crrev.com/1a1ba1bfbbceaa4d591e0e4f19abc5aa0dccacdf/ios/chrome/browser/autofill/form_suggestion_label.mm

Comment 10 by cma...@chromium.org, Sep 13 2017

Labels: -Merge-Request-62 Merge-Approved-62
Merge approved upon verification of the fix on trunk before merging and on branch 3202 after merging.
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 18 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 18 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15ea73a8d331c16fb0f3566ae597904bd01bcfd

commit d15ea73a8d331c16fb0f3566ae597904bd01bcfd
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Mon Sep 18 16:31:18 2017

[Autofill] Uses credit card icons in components instead of imagesets.

- Adds 3x resources to components/resources/autofill. These missing
  resources where causing the ResourceBundle to load the 1x ones for
  iPhone plus devices which resulted in blurry icons.
- Modifies the 1x and 2x resources for the generic credit card to match
  the 3x one.
- Removes the imagesets from iOS bundle and changes the autofill suggestion
  code to use the resources in the components.

TBR=mahmadi@chromium.org

(cherry picked from commit 7cfe1330e2c02792eab7821951263a2c0af3729b)

Bug:  763499 
Change-Id: I5463bc20c30b884ee4685a3fd2cd28d84625a709
Reviewed-on: https://chromium-review.googlesource.com/660802
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501283}
Reviewed-on: https://chromium-review.googlesource.com/671404
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#288}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_100_percent/autofill/cc-generic.png
[modify] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_200_percent/autofill/cc-generic.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/amex.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/cc-generic.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/diners.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/discover.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/jcb.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/mastercard.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/mir.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/unionpay.png
[add] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/components/resources/default_300_percent/autofill/visa.png
[modify] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/ios/chrome/browser/autofill/form_suggestion_label.mm
[modify] https://crrev.com/d15ea73a8d331c16fb0f3566ae597904bd01bcfd/ios/chrome/browser/autofill/resources/BUILD.gn
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_american_express.imageset/autofill_card_american_express~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_diners.imageset/autofill_card_diners~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_discover.imageset/autofill_card_discover~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_generic.imageset/autofill_card_generic~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_jcb.imageset/autofill_card_jcb~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_mastercard.imageset/autofill_card_mastercard~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_unionpay.imageset/autofill_card_unionpay~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/Contents.json
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@2x~ipad.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa@3x.png
[delete] https://crrev.com/91b1823bac291690ba9daf64761fe0609effb3e6/ios/chrome/browser/autofill/resources/autofill_card_visa.imageset/autofill_card_visa~ipad.png
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5092f3d58e36cbbe075b2cfe9fecd7bfaf069c1

commit e5092f3d58e36cbbe075b2cfe9fecd7bfaf069c1
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Mon Sep 18 16:34:45 2017

[Autofill] Fixes a bug where all autofill suggestions have generic-cc icon

Bug:763499

after: https://drive.google.com/file/d/0B-GXJsF3pXyjRm4zbHVsaTFfSGs/view?usp=sharing
before: https://drive.google.com/file/d/0B-GXJsF3pXyjWUx5MG81QWFKNnM/view?usp=sharing

TBR=mahmadi@chromium.org

(cherry picked from commit 1a1ba1bfbbceaa4d591e0e4f19abc5aa0dccacdf)

Change-Id: Iba3625cf83a626b38c4cf338650d0c98f06f674d
Reviewed-on: https://chromium-review.googlesource.com/664217
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501623}
Reviewed-on: https://chromium-review.googlesource.com/671292
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#289}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/e5092f3d58e36cbbe075b2cfe9fecd7bfaf069c1/ios/chrome/browser/autofill/form_suggestion_label.mm

Comment 14 by vbarig...@chromium.org, Sep 20 2017

Status: Verified (was: Fixed)
Verified on chrome beta version 62.0.3202.29.

Devices: iPhone 6s plus, iPhone 6 plus
iOS : 10.3.3, 11.0

The icons looks good and not blur

Screen shot:

https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDbElEc0N4UVJGMnM/view?usp=sharing
►

Sign in to add a comment