New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763491 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

platform_DebugDaemonGetPerfData fails - "Unhandled EOFError:"

Reported by jrbarnette@chromium.org, Sep 8 2017

Issue description

Cc: rajatja@chromium.org denniskempin@chromium.org ejcaruso@chromium.org
 Issue 753604  has been merged into this issue.
Cc: amstan@chromium.org puneetster@chromium.org
Labels: -Pri-3 Pri-1
This test continues to be flaky and is taking out CQ runs:
https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_kitty-paladin/builds/3003
https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_kitty-paladin/builds/2997

Theres potentially some other unaddressed comments in  issue 754604  that were not responded to.

I recommend disabling this test and filing a blocking bug until this flaky test can be resolved since it's from some change that has likely snuck into ToT.
> [ ... ] since it's from some change that has likely snuck into ToT.

Nothing "likely" about it - the evidence is unambiguous that there's
a bug in ToT.

If we can't - or won't - fix the test, the correct change is to
move the test to bvt-perbuild.

Does this happen on multiple boards? I'm not seeing it on my cave.

The test log from the first link in c#3 seems to show that GetPerfData works on the first iteration and fails afterwards, so it's unclear what's broken.
Re c#5, not sure, someone (sheriff, person responsible for the bug/test) will need to answer that question.

In the meantime, I recommend disabling the test to avoid more CQ failures.  In general, when faced with a situation like this which is taking out CQ, get the CQ healthy, then investigate.  Sometimes getting the CQ healthy is an obvious fix, but otherwise, revert or disable test/builder and then investigate.

If jintao@ is not the correct owner (ejcaruso@ owned the other bug), then please reassign accordingly.
Cc: davidri...@chromium.org
Owner: ejcaruso@chromium.org
Reassigning it from old-sheriff to ejcaruso@, owner from duplicate bug.
I think someone assigned this to me because they figured it had something to do with the debugd refactor but if it showed up in M55 and if any perf commands succeed at all then that's not the issue here. In several logs above perf succeeds multiple times before the test keels over so I'm willing to bet there's some issue in perf itself on some boards.

I'm going to move it to bvt-perbuild because of this. Let me know if you think this is the wrong move.
Labels: ReleaseBlock-Stable M-63 OS-Chrome
Marking as release blocker to let TPM decide if we need this test coverage.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5f48c9255287f36cec83e9e48f0b1eebb43bcce9

commit 5f48c9255287f36cec83e9e48f0b1eebb43bcce9
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Sat Sep 23 00:55:29 2017

autotest: move platform_DebugDaemonGetPerfData to bvt-perbuild

This test is flaky for what seems to be no fault of ours, so
remove it from the CQ.

BUG= chromium:763491 
TEST=None

Change-Id: Ic52bba957678018eb36d8b8013f8e96bb273c00b
Reviewed-on: https://chromium-review.googlesource.com/677745
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/5f48c9255287f36cec83e9e48f0b1eebb43bcce9/client/site_tests/platform_DebugDaemonGetPerfData/control

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment