New issue
Advanced search Search tips

Issue 763476 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Overlay scrollbars in subscroller can't be dragged

Project Member Reported by bokan@chromium.org, Sep 8 2017

Issue description

Chrome Version       : 62.0.3202.9
OS Version: Linux
URLs (if applicable) : https://news.ycombinator.com/item?id=15065075

What steps will reproduce the problem?
1. The first reply to the first comment (by avaer) has a horizontally scrollable snippet
2. Scroll it horizontally (using trackpad or shift-wheel)
3. When scrollbar appears, try to drag it

What is the expected result?
Should drag the scrollbar and cause scrolling

What happens instead of that?
Drag misses the scrollbar, selects text instead.

I suspect this is a dup of either  issue 715742  or  issue 756740  but we should investigate and confirm.

 

Comment 1 Deleted

Comment 2 by bokan@chromium.org, Sep 8 2017

Right...probably the other one :)
It is not related to  issue 715742 , since the cc animation is correct.
It is not related to  issue 756740 , since that patch cause  issue 756740  reverted.

It looks like a new hit test issue.

Comment 4 by bokan@chromium.org, Sep 8 2017

Ah, right, I got confused as to what that was tracking and assumed this might be squashing but since the CC animation happens I guess it can't be squashing and must be related to hit testing.
This issue is caused by the size of overlay scrollbar is incorrect, in my debug output, the scrollbar rect(h_bar_rect)[1] is thin rect but scrollbar already expand I check the FrameRect is correct. You can move the mouse to almost the bottom of scrollbar then you can drag the scrollbar.

Tried change the Y of scrollbar calculation to: (Box().BorderTop().ToInt() + VisibleContentRect(kIncludeScrollbars).Height() - HorizontalScrollbar()->ScrollbarThickness()). Then the hit test include scrollbar.

Then I found another issue for this: ScrollbarTheme::HitTest return NoPart. ConvertFromRootFrame return an incorrect point, it seems something calc twice. Need more investigation.

Demo: http://ht.chaopeng.me/scrollbar-hit-test-wrong.html

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp?rcl=a16189bedba98586e1360666460717f88b63d8ee&l=1518
Cc: bokan@chromium.org chaopeng@chromium.org
Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: szager@chromium.org
This is a regression introduced from 01cf6fd553bcc6d5a9ca6763eed42fbca5ecc494. 
Stefan, Could you please take a look. Thank you.

Comment 7 by danakj@chromium.org, Oct 27 2017

ping? This is P1 but no action in a while.
I'm unable to reproduce this in version 63.0.3239.9 (Linux desktop).  I can scroll the region using shift-wheel.

The overflowing element has overflow:auto, so I'm not sure why comment #5 mentions overlay scrollbars.  I'm also unable to reproduce the demo from that comment.
szager@ this needs turn on overlay scrollbar

--enable-features=OverlayScrollbar --enable-prefer-compositing-to-lcd-text
I can reproduce at 64.0.3258.0
Status: WontFix (was: Assigned)
Can not reproduce in CrOS in 67.0.3833.0 and Linux in ToT.

Sign in to add a comment