New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763475 link

Starred by 1 user
Status: Fixed
Owner:
asvitk...@chromium.org
Closed: Sep 2017
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Stack sampling profiler reporting base::Feature is not checked

Project Member Reported by asvitk...@chromium.org, Sep 8 2017 
Stack sampling profiler reporting base::Feature is not checked
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b0ad91d5f12a50faab31a716d00680002e8328

commit 47b0ad91d5f12a50faab31a716d00680002e8328
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Fri Sep 08 21:05:13 2017

Fix missing check for sampling profiler enable reporting feature.

Also removes the wrapper function since things are simpler with
the base::Feature API.

BUG= 763475 

Change-Id: I5d0861205e5c8b088ac780d525c3bbfdccea85e6
Reviewed-on: https://chromium-review.googlesource.com/658121
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500659}
[modify] https://crrev.com/47b0ad91d5f12a50faab31a716d00680002e8328/components/metrics/call_stack_profile_metrics_provider.cc
[modify] https://crrev.com/47b0ad91d5f12a50faab31a716d00680002e8328/components/metrics/call_stack_profile_metrics_provider.h

Comment 2 by asvitk...@chromium.org, Sep 8 2017

Labels: M-63
Status: Fixed (was: Started)
►

Sign in to add a comment