New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763472 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: fix guest mode messaging

Project Member Reported by scottchen@chromium.org, Sep 8 2017

Issue description

Guest mode should not be able to navigate to chrome:extensions and see the page.
 
In the old extensions page a guest can navigate there, they just don't see the extensions. Should we do the same?

I'd rather show *something* that show a 404 page or similar. Even a page that just says that "Extension management is not available to Guest users. Please sign in to manage extensions".
Cc: -devlin@chromium.org rdevlin....@chromium.org
Attached are screenshots of what we do in the old extensions and md-extensions page for Guest mode. It’s essentially the same.

As dschuyler@ suggests, we could add a string that says "Extension management is not available to Guest users. Please sign in to manage extensions". Maybe we should even remove the link to the Chrome Web Store because CWS will not permit extension downloading anyway.
old-extensions-guest-mode.png
137 KB View Download
md-extensions-guest-mode.png
132 KB View Download
Cc: catmulli...@chromium.org
Labels: -Pri-1 Pri-2
Summary: MD Extensions: fix guest mode messaging (was: MD Extensions: block guest mode)
updated bug title to reflect suggested solution.
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1737756ee2496fa7e939723fc36e0dcc2f1616d9

commit 1737756ee2496fa7e939723fc36e0dcc2f1616d9
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Oct 11 01:04:19 2017

MD Extensions: change guest mode messaging

Bug:  763472 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4fa187701c831d98ece924f5de1a4d84cbe76cf8
Reviewed-on: https://chromium-review.googlesource.com/706425
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507844}
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/item_list.js
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/resources/md_extensions/toolbar.js
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/1737756ee2496fa7e939723fc36e0dcc2f1616d9/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Status: Fixed (was: Started)

Sign in to add a comment