New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763466 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

v8.detached_context_age_in_gc failing on 21 builders

Project Member Reported by eakuefner@chromium.org, Sep 8 2017

Issue description

v8.detached_context_age_in_gc failing on 21 builders

Builders failed on: 
- Android Nexus5 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf
- Android Nexus5X Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf
- Android Nexus5X WebView Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf
- Android Nexus6 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf
- Android Nexus6 WebView Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf
- Android Nexus7v2 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf
- Android One Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf
- Linux Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf
- Mac 10.11 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf
- Mac 10.12 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf
- Mac Air 10.11 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf
- Mac Pro 10.11 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%20Pro%2010.11%20Perf
- Mac Retina Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf
- Win 10 High-DPI Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf
- Win 10 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf
- Win 7 Intel GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf
- Win 7 Nvidia GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf
- Win 7 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf
- Win 7 x64 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf
- Win 8 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf

This failure seems due to WPR Go error. Stack trace with a few log lines:

Traceback (most recent call last):
  RunBenchmark at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:332
    expectations=expectations, metadata=benchmark.GetMetadata())
  Run at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:203
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:98
    state.WillRunStory(story)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  WillRunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:241
    archive_path, page.make_javascript_deterministic)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  StartReplay at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/core/network_controller.py:42
    make_javascript_deterministic)
  StartReplay at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:193
    local_ports = self._StartReplayServer()
  _StartReplayServer at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/network_controller_backend.py:227
    return self._wpr_server.StartServer()
  StartServer at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/util/webpagereplay_go_server.py:283
    ''.join(self._LogLines()))
ReplayNotStartedError: Web Page Replay failed to start. Log output:
2017/09/08 05:30:58 Loading cert from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_cert.pem
2017/09/08 05:30:58 Loading key from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_key.pem
2017/09/08 05:30:58 Loading script from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/deterministic.js
Error openining archive file: gunzip failed: gzip: invalid header

Locals:
  is_posix : True
  log_fh   : <closed file '/b/swarming/w/it2hCdnC/tmp62RQ3C', mode 'w' at 0x7f7d04021390>

 
Owner: u...@chromium.org
Status: Assigned (was: Available)
Cc: u...@chromium.org
Owner: xunji...@chromium.org
Actually based on the log, this seems like a wprgo bug:

ReplayNotStartedError: Web Page Replay failed to start. Log output:
2017/09/12 11:25:31 Loading cert from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_cert.pem
2017/09/12 11:25:31 Loading key from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_key.pem
2017/09/12 11:25:31 Loading script from /b/swarming/w/ir/third_party/catapult/web_page_replay_go/deterministic.js
Error openining archive file: gunzip failed: gzip: invalid header

https://chromium-swarm.appspot.com/task?id=388e4b6da9dd9f10&refresh=10

Helen: can you take a look?

I can reproduce this on my desktop easily with:

./tools/perf/run_benchmark v8.detached_context_age_in_gc --browser=system
Looks like a corrupted archive. I will take a look tomorrow.
Cc: wkorman@chromium.org
This benchmarks uses "top_25_009.wprgo" which is of the old wpr format. You can see if it is of legacy format by opening it using a text editor. There are strings like "ArchivedHttpRequest" which is from the python WPR. The archive was added in r71d0b6e55036e66e74dde48b1c7d5364eb1e5b1d.

My guess is that record_wpr ran a few times, and during the last time it wrote archive file with the legacy format.

I will re-record it.


Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5df2babd123895496476374c0835cd64f9ec8f

commit ce5df2babd123895496476374c0835cd64f9ec8f
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Sep 13 16:16:53 2017

Fix top_25_009.wprgo

top_25_009.wprgo is of the legacy format. This causes WprGo server to error out
when trying to unzip the archive. See attached bug for more detail.
I converted to the new .wprgo format using
tools/perf/convert_legacy_wpr_archive.

Bug:  763466 
Change-Id: I32b37852147b6cf70c0ded34906b08988d2fd455
Reviewed-on: https://chromium-review.googlesource.com/665061
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501651}
[modify] https://crrev.com/ce5df2babd123895496476374c0835cd64f9ec8f/tools/perf/page_sets/data/top_25_009.wprgo.sha1

Components: Speed>Benchmarks
Status: Fixed (was: Assigned)
This should be fixed. I tested it locally.
Cc: nedngu...@google.com
 Issue 764864  has been merged into this issue.

Sign in to add a comment