New issue
Advanced search Search tips

Issue 763464 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 760181



Sign in to add a comment

ContentBrowserTests-Viz: TestRenderWidgetHostView

Project Member Reported by jonr...@chromium.org, Sep 8 2017

Issue description

TestRenderWidgetHostView has dependencies on:
  -  components/viz/common/surfaces/frame_sink_id.h
  -  components/viz/host/host_frame_sink_client.h
  -  viz::mojom::CompositorFrameSinkClient
  -  viz::LocalSurfaceId
  -  viz::FrameSinkId
  -  viz::SurfaceInfo
  -  components/viz/service/frame_sinks/frame_sink_manager_impl.h
  -  components/viz/service/surfaces/surface_manager.h

Find out how the Viz process split impacts this test, and update.
 
Status: WontFix (was: Untriaged)
The viz/service/ includes are no longer used.
The rest is fine.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f507cbe3282cec5b6915962aefab77aa89cd835

commit 4f507cbe3282cec5b6915962aefab77aa89cd835
Author: Jonathan <jonross@chromium.org>
Date: Fri Sep 15 19:09:14 2017

Removing unused viz imports from content tests

Removing some unused viz imports from content tests.

TBR=sky@chromium.org

TEST: compiled content_unittests and content_browsertests
Bug:  762514 ,  762526 ,  764802 ,  763464 
Change-Id: I30c6bd3e96bb90b4aa4464163b73e1138a724e61
Reviewed-on: https://chromium-review.googlesource.com/668666
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502326}
[modify] https://crrev.com/4f507cbe3282cec5b6915962aefab77aa89cd835/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
[modify] https://crrev.com/4f507cbe3282cec5b6915962aefab77aa89cd835/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/4f507cbe3282cec5b6915962aefab77aa89cd835/content/test/content_browser_test_utils_internal.h
[modify] https://crrev.com/4f507cbe3282cec5b6915962aefab77aa89cd835/content/test/test_render_view_host.cc

Status: Fixed (was: WontFix)
Removed the unused import

Comment 4 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.

Sign in to add a comment