New issue
Advanced search Search tips

Issue 763458 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Mar 2018
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 760320



Sign in to add a comment

ContentBrowserTests-Viz: MockRenderProcessHost

Project Member Reported by jonr...@chromium.org, Sep 8 2017 
MockRenderProcessHost has dependencies on:
  -  components/viz/service/display_embedder/shared_bitmap_allocation_notifier_impl.h
  -  components/viz/service/display_embedder/server_shared_bitmap_manager.h

Find out how the Viz process split impacts this test, and update.

Comment 1 by jonr...@chromium.org, Sep 14 2017 

This is replicating an aspect that is being moved for the viz split.
It is supplying shared bitmaps to RenderWidgetHostImpl and will need updating at the same time.

We may need a test version of SharedBitmapAllocationNotifierImpl.

Comment 2 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.

Comment 3 by jonr...@chromium.org, Nov 13 2017 

The only browsertest variant of this is in browser_tests which is not being run with --enable-viz yet.

The majority of the usages are unittests. For the unittests we need a mock variant of SharedBitmapAllocationNotifierImpl, which can be used directly.

For the browsertest we will need to make a mojom for SharedBitmapAllocationNotifierImpl, which can then notify across the process boundary.

Comment 4 by jonr...@chromium.org, Nov 14 2017

Blocking: -760181 760320

Comment 5 by jonr...@chromium.org, Mar 9 2018

Status: Fixed (was: Untriaged)
DeclarativeContentConditionTrackerTest - only used in unit_tests - fine
SpellcheckServiceBrowserTest - currently all passes.

I'll close this for now as there seems to be no actions to take.
►

Sign in to add a comment