New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763455 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Open play.google.com links directly on ARC.

Project Member Reported by djacobo@chromium.org, Sep 8 2017

Issue description

Opening play.google.com links directly to ARC would be better for ARC enabled devices.

The current experience doesn't trigger the intent picker nor redirects the user to the play store since both the search page (google.com) and the play page (play.google.com) share the same domain, and we set a rule for these kind of navigation to not trigger the UI.

Internal tracker here b/63771248
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58204ed88e3df04eb92ff633c8fa006e4392cead

commit 58204ed88e3df04eb92ff633c8fa006e4392cead
Author: djacobo <djacobo@google.com>
Date: Fri Sep 08 22:50:00 2017

Allow play.google.com links redirect to ARC.

This CL adds a special case so play.google.com links can be redirected
to ARC even if both the URL of the current page and the one we are
navigating to have the same domain (google.com), this should allow the
user to redirect the search straight to the Play Store (on ARC).

Bug:  763455 
Test: Adding a handful of cases to check this via unittest.
Change-Id: I9b51f6d9241b98e84c96c5117f68b82e41ab1ec2
Reviewed-on: https://chromium-review.googlesource.com/657199
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@google.com>
Cr-Commit-Position: refs/heads/master@{#500720}
[modify] https://crrev.com/58204ed88e3df04eb92ff633c8fa006e4392cead/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
[modify] https://crrev.com/58204ed88e3df04eb92ff633c8fa006e4392cead/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

Comment 2 by djacobo@google.com, Sep 11 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0a8c2aa2c837f8d182cde8f08b51b1c9543dbdd

commit c0a8c2aa2c837f8d182cde8f08b51b1c9543dbdd
Author: David Jacobo <djacobo@chromium.org>
Date: Thu Sep 14 01:09:52 2017

Modify ArcNavigationThrottle rules

Instead of special casing for play.google.com links, we can allow the
ArcNavigationThrottle to query ARC for apps when the navigation is
taking case from and to the google.com domain iff the host is different.

Original CL here: crrev.com/c/666063

Bug:  763455 
Test: Unit tests fixed accordingly.
Change-Id: I41f074bf19582d87bc2371f58fa99f787b658cd8
Reviewed-on: https://chromium-review.googlesource.com/666230
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501821}
[modify] https://crrev.com/c0a8c2aa2c837f8d182cde8f08b51b1c9543dbdd/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
[modify] https://crrev.com/c0a8c2aa2c837f8d182cde8f08b51b1c9543dbdd/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment