New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763454 link

Starred by 1 user
Status: WontFix
Owner:
█ hjd@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
perezju@chromium.org
etienneb@chromium.org
benjhayden@chromium.org
ssid@chromium.org
primiano@chromium.org
█ hjd@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Traces with multiple memory dump events with the same guid are incorrectly parsed.

Project Member Reported by erikc...@chromium.org, Sep 8 2017 
ToT: 763dc3cb872af70b9bfa8fd218b77e963c4907d3

To repro, build from the following ToT and patch in memlog.diff. I used macOS, but this should work on all OSes.

Taking a trace using chrome://tracing. Notice that there are two "detailed" dumps. The first has all the MDP information, the second has just a memlog heap dump, including the field shim_allocated_objects*

Now uncomment the line: "// guid = args.dump_guid;". This causes the memlog heap dump to have the same guid as the original dump.

Take a trace using chrome://tracing. Now, there is a single "detailed" dump, and the allocations show up correctly, but the shim_allocated_objects* fields disappear.

More relevant, when running telemetry benchmarks, e.g.
"""
./tools/perf/run_benchmark --browser=exact --browser-executable=./out/gn/Chromium.app/Contents/MacOS/Chromium --extra-browser-args="--memlog=browser" system_health.memory_desktop --story-filter='load:search:amazon' --pageset-repeat=1 --output-format=json --output-format=html
"""

Running with ToT correctly extracts the shim_allocated_objects_size field, but forcing the dumps to merge with the same guid causes the field to not be extracted.
memlog.diff
2.7 KB Download

Comment 1 by erikc...@chromium.org, Sep 8 2017

Cc: etienneb@chromium.org

Comment 2 by hjd@chromium.org, Sep 12 2017

Owner: hjd@chromium.org
Status: Assigned (was: Untriaged)
Do you have an example trace to hand? Otherwise I will try to build with that patch tomorrow.

Comment 3 by erikc...@chromium.org, Sep 28 2017

Status: WontFix (was: Assigned)
I tried this recently...and now get:
"""
Loading Histogram 0 of 1032
"""

results.html no longer loads? Anyways, will close for now and reopen when we try to turn on --memlog for memory perf tests.

Comment 4 by sullivan@chromium.org, Sep 28 2017

Cc: benjhayden@chromium.org
cc benjhayden for error in #3
►

Sign in to add a comment