New issue
Advanced search Search tips

Issue 763447 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

merge window mappings in WindowServer

Project Member Reported by riajiang@chromium.org, Sep 8 2017

Issue description

Currently we have three mappings in WindowServer for each client:
1. WindowId -> ClientWindowId
(https://cs.chromium.org/chromium/src/services/ui/ws/window_tree.h?type=cs&pv=1&l=664)
2. ClientWindowId -> WindowId
(https://cs.chromium.org/chromium/src/services/ui/ws/window_tree.h?type=cs&pv=1&l=662)
3. WindowId -> ServerWindow
(https://cs.chromium.org/chromium/src/services/ui/ws/window_tree.h?type=cs&pv=1&l=656)

ServerWindow has an id_ field for WindowId and a frame_sink_id_. Now that frame_sink_id_ is the ClientWindowId, we can have two mappings instead:
1. WindowId -> ServerWindow
2. ClientWindowId -> ServerWindow
which should cover all use cases that we have in WindowServer.

 
Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash-Mus-WS
Deprecating label Proj-Mustash-Mus-WS in favor of Components.
Labels: -Proj-Mustash-Mus
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Status: Fixed (was: Available)
We are down to two now:
aura::Window->ClientWindowId
ClientWindowId->aura::Window*

Sign in to add a comment