Extend Domain Reliability to third-parties |
||||||||||
Issue descriptionDomain Reliability has baked-in configs. The medium-term plan is to ship the standards-based Network Error Logging and remove Domain Reliability. However, in the interim there is interest in having a small number of third-parties experiment and provide feedback about the effectiveness. To prevent this from becoming a de-facto standard, the plan is to allow this extension but to restrict to a small-number of third-party domains (16) for a small amount of time (~3 months or 2 Chrome release cycles). This is only a configuration change and has no code requirement change.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/880af477a8b12b77e871c29cf0ea4e2515fba3d4 commit 880af477a8b12b77e871c29cf0ea4e2515fba3d4 Author: Julia Tuttle <juliatuttle@chromium.org> Date: Thu Oct 19 20:17:46 2017 Domain Reliability / NEL: Add third-party domains for prototyping Bug: 763433 Change-Id: Id314290c18ff7d6c7d2f2c4c995002a3434d734e Reviewed-on: https://chromium-review.googlesource.com/648028 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#510180} [modify] https://crrev.com/880af477a8b12b77e871c29cf0ea4e2515fba3d4/components/domain_reliability/google_configs.cc
,
Oct 30 2017
This has been fine in canaries; requesting merges to 63 and 62.
,
Oct 30 2017
The bug is marked as P3 or Feature. It should not be merged as M63 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30 2017
This isn't really a feature or a bug, it's a config change.
,
Oct 30 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30 2017
There we go.
,
Oct 30 2017
Oops, not actually merging into 62, sorry.
,
Oct 31 2017
Before we approve merge to M63, could you pls confirm followings? Is this M63 regression and critical to merge? Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge? Any other imp details to justify the merge. Please note M63 is already promoted to Beta so merge bar is very high. Thank you.
,
Oct 31 2017
This is not a regression, just a config update. I'll let cbentzel chime in on whether we consider this critical. It's baked in canary, but since it's a config change, there's no specific test coverage for the change. It adds origins to Domain Reliability, but those origins use the same code paths as before. Implementation-wise, I'd reiterate that this isn't changing any code paths, so I'd consider it lower-risk.
,
Oct 31 2017
This is not a regression. Given the low technical risk of this change I would recommend merge.
,
Oct 31 2017
Approving merge to M63 branch 3239 based on comment #10 and #11. Please merge ASAP so we can take it for tomorrow's beta release. Thank you.
,
Oct 31 2017
Thanks a bunch! Merging right now.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d41909b3c7d8a07251ffdcc63e0888101e9c89da commit d41909b3c7d8a07251ffdcc63e0888101e9c89da Author: Julia Tuttle <juliatuttle@chromium.org> Date: Tue Oct 31 18:34:59 2017 Domain Reliability / NEL: Add third-party domains for prototyping TBR=juliatuttle@chromium.org (cherry picked from commit 880af477a8b12b77e871c29cf0ea4e2515fba3d4) Bug: 763433 Change-Id: Id314290c18ff7d6c7d2f2c4c995002a3434d734e Reviewed-on: https://chromium-review.googlesource.com/648028 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by: Chris Bentzel <cbentzel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510180} Reviewed-on: https://chromium-review.googlesource.com/747461 Reviewed-by: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#318} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/d41909b3c7d8a07251ffdcc63e0888101e9c89da/components/domain_reliability/google_configs.cc
,
Jan 5 2018
This is working and we're receiving data for those third parties.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4697720592b586a632a8d6e6ed91bd773a0bec40 commit 4697720592b586a632a8d6e6ed91bd773a0bec40 Author: Julia Tuttle <juliatuttle@chromium.org> Date: Wed Feb 14 16:37:03 2018 Domain Reliability: Remove third-party domains added for testing. Bug: 763433 Change-Id: Id87010fd5d25122500be8b80efe56fe446dd8633 Reviewed-on: https://chromium-review.googlesource.com/916581 Reviewed-by: Chris Bentzel <cbentzel@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#536735} [modify] https://crrev.com/4697720592b586a632a8d6e6ed91bd773a0bec40/components/domain_reliability/google_configs.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by cbentzel@chromium.org
, Sep 8 2017