New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763432 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Auto-dismiss non-blocking issues after a certain amount of time has passed

Project Member Reported by imch...@chromium.org, Sep 8 2017 
Sometimes a user does not notice an issue has come up during an attempt to cast (regardless of whether the attempt succeeded), only to notice (much) later in time by looking at the cast icon in browser menu and/or opening the MR dialog. The user could be confused since the issue is stale and they may not connect it with the earlier casting activity. We could potentially improve UX by auto-dismissing certain issues that are not blocking. I propose the following:

- auto-dismiss notification issues after 1 minute
- auto-dismiss non-notification non-blocking issue after 5 minutes


 Bug 655376  is related, which also helps clear up stale issues.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/398990826f949d2904d710652184e51fea121dd9

commit 398990826f949d2904d710652184e51fea121dd9
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Sep 12 17:57:01 2017

[Media Router] Auto-dimiss non-blocking issues part 1.

This patch implements the following:
- auto-dismiss notification issues after 1 minute
- auto-dismiss non-notification non-blocking issue after 5 minutes

This is done by posting a task to clear a given issue after it has been
added to the IssueManager.

Part 2 will be to dismiss non-blocking issues following a successful
cast from the Media Router UI.

Bug:  763432 
Change-Id: I6c55d4c272b8fc09b48935c6d4011d893e0cea58
Reviewed-on: https://chromium-review.googlesource.com/658138
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501334}
[modify] https://crrev.com/398990826f949d2904d710652184e51fea121dd9/chrome/browser/media/router/issue_manager.cc
[modify] https://crrev.com/398990826f949d2904d710652184e51fea121dd9/chrome/browser/media/router/issue_manager.h
[modify] https://crrev.com/398990826f949d2904d710652184e51fea121dd9/chrome/browser/media/router/issue_manager_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fb6f7e32a3386864627a23cb8a16e5dba48c29

commit e3fb6f7e32a3386864627a23cb8a16e5dba48c29
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Sep 19 00:58:02 2017

[Media Router] Auto-dismiss Issues part 2.

When attempting to cast via the dialog, clear previous non-blocking
issues. This ensures issues are cleared on a successful cast, or that
the newest issue is displayed if otherwise.

This patch also simplifies the MediaRouter API by replacing the various
Issues-related API in MediaRouter with GetIssueManager().
GetIssueManager() is implemented in MediaRouterBase, making it also
available on Android.

Also combined the Issues and their auto-dismiss callbacks in
IssueManager into an Entry maintained in a single container.

Bug:  763432 
Change-Id: Iaa79f991760fa31e28ec50d0e23cbf8b9f39a28a
Reviewed-on: https://chromium-review.googlesource.com/663104
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502739}
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/issue_manager.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/issue_manager.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/issue_manager_unittest.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/issues_observer.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/issues_observer.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/toolbar/media_router_action_controller.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/e3fb6f7e32a3386864627a23cb8a16e5dba48c29/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

Comment 3 by imch...@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment