New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763428 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Log TetherFeatureState

Project Member Reported by khorimoto@chromium.org, Sep 8 2017

Issue description

It's difficult to debug why Instant Tethering is in the state that it is. It would be advantageous to log this.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978d6addb11e78af654770a216141b82cb478736

commit 978d6addb11e78af654770a216141b82cb478736
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Sep 08 19:11:06 2017

[CrOS Tether] Add state-change logs to TetherService.

This will help debug issues in which the component does not start up.

Bug:  763428 , 672263
Change-Id: Ie1da037006f8448aeba1d77344501fb068339a3a
Reviewed-on: https://chromium-review.googlesource.com/657268
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500635}
[modify] https://crrev.com/978d6addb11e78af654770a216141b82cb478736/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/978d6addb11e78af654770a216141b82cb478736/chrome/browser/chromeos/tether/tether_service.h

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a5559eda453912a60aa6e794c62b71c1863f5f1

commit 9a5559eda453912a60aa6e794c62b71c1863f5f1
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Sep 08 19:20:06 2017

[CrOS Tether] Add state-change logs to TetherService.

This will help debug issues in which the component does not start up.

TBR=khorimoto@google.com

(cherry picked from commit 978d6addb11e78af654770a216141b82cb478736)

Bug:  763428 , 672263
Change-Id: Ie1da037006f8448aeba1d77344501fb068339a3a
Reviewed-on: https://chromium-review.googlesource.com/657268
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500635}
Reviewed-on: https://chromium-review.googlesource.com/657886
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1144}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9a5559eda453912a60aa6e794c62b71c1863f5f1/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/9a5559eda453912a60aa6e794c62b71c1863f5f1/chrome/browser/chromeos/tether/tether_service.h

Status: Fixed (was: Started)
Labels: Merge-Request-62
Status: Started (was: Fixed)
Will re-close when merge to M-62 has completed.
Labels: -Merge-Request-62 Merge-Approved-62
Approved for 62.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 11 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e65eefe2b9e95524a7b81e9618aa17c0806ae9b

commit 6e65eefe2b9e95524a7b81e9618aa17c0806ae9b
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Sep 11 18:21:40 2017

[CrOS Tether] Add state-change logs to TetherService.

This will help debug issues in which the component does not start up.

TBR=khorimoto@google.com

(cherry picked from commit 978d6addb11e78af654770a216141b82cb478736)

Bug:  763428 , 672263
Change-Id: Ie1da037006f8448aeba1d77344501fb068339a3a
Reviewed-on: https://chromium-review.googlesource.com/657268
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500635}
Reviewed-on: https://chromium-review.googlesource.com/660413
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#138}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6e65eefe2b9e95524a7b81e9618aa17c0806ae9b/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/6e65eefe2b9e95524a7b81e9618aa17c0806ae9b/chrome/browser/chromeos/tether/tether_service.h

Status: Fixed (was: Started)

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 13 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment