Issue 763426 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	est...@chromium.org
Closed:	Oct 2017
Cc:	peter@chromium.org
Components:	UI>Notifications
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	2
Type:	Bug

Blocking:
issue 755413

Remove chrome/browser/notification/notification.* (merge with message center version)

Project Member Reported by est...@chromium.org, Sep 8 2017

Issue description

Both Notification and NotificationDelegate in chrome/browser/ extend classes of the same name in the Message Center, which is confusing and to the best of my ability to determine is unnecessary. The c/b/NotificationDelegate adds just an id(), which is already part of mc::Notification, and not at this point distinct. When c/b/Notification is removed I can't see a reason for c/b/Notification to exist either.

Comment 1 by est...@chromium.org, Sep 11 2017

Blocking: 755413
Components: UI>Notifications
Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf

commit 7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 13 01:52:00 2017

Start converting Chrome NotificationDelegate instances to
message_center::NotificationDelegates.

The Chrome specialization of this class just adds an id, but that
id is always piped through to the underlying notification as the
notification's id, so it's redundant.

This patch introduces a new ctor for Chrome's Notification and
switches over a couple of delegates. It also removes the
delegate_id() pass through from Chrome's Notification since
it's always the same as id(). Only a couple of NotificationDelegates
are switched to extend message_center::NotificationDelegate, the
rest are TODOs.

It remains to be seen whether we can remove Chrome's Notification
tag, but since the JS provided tag is cooked into the ID and for
most non-web notifications the tag is identical to the id, I'm
hopeful.

TBR=stevenjb@chromium.org

Bug:  763426 
Change-Id: I69ced05e25129d428318fd10232eb20e7a8c4d0c
Reviewed-on: https://chromium-review.googlesource.com/657599
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501509}
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/chromeos/hats/hats_notification_controller.h
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/notification.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/notification.h
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/notification_test_util.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/profile_notification.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/7ff08dc7700829e4d0dd5c100faeee7fe4ad0ddf/chrome/browser/status_icons/desktop_notification_balloon.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc9cd096f598e5b00b60f85e7efb246b8c865bda

commit fc9cd096f598e5b00b60f85e7efb246b8c865bda
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 15 21:15:03 2017

Convert the rest of existing chrome/browser/NotificationDelegates to
message_center::NotificationDelegate and remove the former class.

Bug:  763426 
Change-Id: Ia62b8f193f4fd2ccbc988121b07162186aa344f8
Reviewed-on: https://chromium-review.googlesource.com/661794
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502375}
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/BUILD.gn
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/hats/hats_notification_controller.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/chromeos/printing/cups_print_job_notification.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification.h
[delete] https://crrev.com/1995792b06f8d4b4ef43b3c56926d03c4df8fc0f/chrome/browser/notifications/notification_delegate.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification_test_util.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/notification_test_util.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/web_notification_delegate.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/notifications/web_notification_delegate.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/printing/cloud_print/privet_notifications.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/search/hotword_service.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/status_icons/desktop_notification_balloon.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/extensions/extension_installed_notification.h
[modify] https://crrev.com/fc9cd096f598e5b00b60f85e7efb246b8c865bda/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e5c67abd6325c2c316fa9a9430b85079174f0d6

commit 1e5c67abd6325c2c316fa9a9430b85079174f0d6
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 20 19:48:19 2017

Extra Notification/NotificationDelegate cleanup.

A missing detail that should have been part of fc9cd096f598e5b00b60f85e7

Bug:  763426 
Change-Id: Ia2cd8c9fb2aea29a50cb6111edee169e53bea6ee
Reviewed-on: https://chromium-review.googlesource.com/670020
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503229}
[modify] https://crrev.com/1e5c67abd6325c2c316fa9a9430b85079174f0d6/chrome/browser/notifications/notification.cc
[modify] https://crrev.com/1e5c67abd6325c2c316fa9a9430b85079174f0d6/chrome/browser/notifications/notification.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71

commit 4ebefdf4adcad39d9076d5ac38166e8d93a8ba71
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 21 23:50:18 2017

Move Notification::service_worker_scope into a new notification metadata
class.

It seems confusing to let Notification become cluttered by extra fields
that are type specific.

Bug:  763426 
Change-Id: I202f10cca7b2637fd696897616cadf1f0c44e93f
Reviewed-on: https://chromium-review.googlesource.com/669687
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503614}
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/message_center_display_service.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/native_notification_display_service.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_common.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_display_service_tester.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_display_service_tester.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_android.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_linux.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_mac.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/4ebefdf4adcad39d9076d5ac38166e8d93a8ba71/chrome/browser/notifications/stub_notification_display_service.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4755cf2fce350283c7d5009571420d9d4be08fb2

commit 4755cf2fce350283c7d5009571420d9d4be08fb2
Author: Evan Stade <estade@chromium.org>
Date: Tue Oct 17 18:35:43 2017

Remove chrome/browser/notifications/notification.*

- Remove Notification::tag_ (for web notification types, where this is relevant,
  the tag, if provided, is cooked into the ID)
- Replace notifications based on ID (along with profile). For most notifications,
  this should be a no-op. For those that previously didn't specify tags, this may
  mean less notification spam as two notifications with the same ID will not
  be shown together.
- Remove c/b/notifications/Notification and just use message_center::Notification.

Bug:  763426 
Change-Id: Id9ef84a40c51b28f27b951ca27e357c53408b998
Reviewed-on: https://chromium-review.googlesource.com/699797
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509437}
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/BUILD.gn
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/android/ntp/content_suggestions_notifier_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/background/background_contents_service_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/hats/hats_notification_controller.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/printing/cups_print_job_notification.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/chromeos/printing/fake_cups_print_job_manager.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/notifications/extension_notification_display_helper.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/notifications/notifications_api.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_display_service.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_notification_manager.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_notification_manager_interactive_uitest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/native_notification_display_service.h
[delete] https://crrev.com/0af01a8d57b03fd2174bd0faa4986572dab89a39/chrome/browser/notifications/notification.cc
[delete] https://crrev.com/0af01a8d57b03fd2174bd0faa4986572dab89a39/chrome/browser/notifications/notification.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_display_service_tester.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_display_service_tester.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_android.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_linux.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_mac.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_platform_bridge_win.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_template_builder_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_test_util.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_test_util.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/notification_ui_manager.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/profile_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/profile_notification.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/notifications/stub_notification_display_service.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/search/hotword_service.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/status_icons/desktop_notification_balloon.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/ash/chrome_screenshot_grabber.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
[modify] https://crrev.com/4755cf2fce350283c7d5009571420d9d4be08fb2/chrome/test/BUILD.gn

Comment 7 by est...@chromium.org, Oct 17 2017

Status: Fixed (was: Started)

►

Issue 763426 link

Issue metadata

Remove chrome/browser/notification/notification.* (merge with message center version)

Issue description

Comment 1 by est...@chromium.org, Sep 11 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 13 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 21 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

Comment 6 Deleted

Comment 7 by est...@chromium.org, Oct 17 2017

Comment 7 Deleted

Sign in to add a comment