Table cell with visibility:hidden hides shared collapsed borders of visible cells below and right |
|||||
Issue descriptionSee the attached test case. They should produce the same results. This was caused by the collapsed border optimization (https://chromium-review.googlesource.com/528561). I'm not marking this bug as a regression because cell visibility hidden behavior is not clearly defined in the spec and browsers have different implementations ( bug 714583 ). This bug is just for keeping the original behavior.
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9b8d1127ddfd9437ad47a1823ccf763798a26fd commit d9b8d1127ddfd9437ad47a1823ccf763798a26fd Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Sep 08 23:50:42 2017 Paint start/before collapsed borders if the adjacent cell is invisible Bug: 763420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib1cebece7f87da4a33894765b1101f02eb374f27 Reviewed-on: https://chromium-review.googlesource.com/658063 Reviewed-by: Robert Hogan <robhogan@gmail.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#500743} [add] https://crrev.com/d9b8d1127ddfd9437ad47a1823ccf763798a26fd/third_party/WebKit/LayoutTests/paint/tables/collapsed-border-cell-visibility-expected.html [add] https://crrev.com/d9b8d1127ddfd9437ad47a1823ccf763798a26fd/third_party/WebKit/LayoutTests/paint/tables/collapsed-border-cell-visibility.html [modify] https://crrev.com/d9b8d1127ddfd9437ad47a1823ccf763798a26fd/third_party/WebKit/Source/core/paint/CollapsedBorderPainter.cpp
,
Sep 9 2017
,
Sep 10 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1463ecc7a952b148744691205afb28d1bececd32 commit 1463ecc7a952b148744691205afb28d1bececd32 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Sep 11 16:37:17 2017 Paint start/before collapsed borders if the adjacent cell is invisible TBR=wangxianzhu@chromium.org (cherry picked from commit d9b8d1127ddfd9437ad47a1823ccf763798a26fd) Bug: 763420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib1cebece7f87da4a33894765b1101f02eb374f27 Reviewed-on: https://chromium-review.googlesource.com/658063 Reviewed-by: Robert Hogan <robhogan@gmail.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500743} Reviewed-on: https://chromium-review.googlesource.com/660839 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#125} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [add] https://crrev.com/1463ecc7a952b148744691205afb28d1bececd32/third_party/WebKit/LayoutTests/paint/tables/collapsed-border-cell-visibility-expected.html [add] https://crrev.com/1463ecc7a952b148744691205afb28d1bececd32/third_party/WebKit/LayoutTests/paint/tables/collapsed-border-cell-visibility.html [modify] https://crrev.com/1463ecc7a952b148744691205afb28d1bececd32/third_party/WebKit/Source/core/paint/CollapsedBorderPainter.cpp
,
Sep 11 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wangxianzhu@chromium.org
, Sep 8 2017