New issue
Advanced search Search tips

Issue 763406 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

9.4%-47% regression in system_health.memory_mobile at 499965:500105

Project Member Reported by rmcilroy@chromium.org, Sep 8 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=763406

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c08ddff82e7c525d1d7be38a3e17cfcbe8078af8d449f07651ce1375aaa191d4


Bot(s) for this bug's original alert(s):

android-nexus5X
android-one
Cc: xidac...@chromium.org
Owner: xidac...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author xidachen@chromium.org ===

Hi xidachen@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Xida Chen
  Commit : 8d1900b0fd708cbe8b298a4f5d8a4cb566007255
  Date   : Wed Sep 06 19:19:19 2017
  Subject: Manually revert: cc: Support ClipRRect in SolidColorAnalyzer

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/load_news/load_news_irctc
  Change       : 46.01% | 52354259.3333 -> 76440273.3333

Revision             Result                   N
chromium@500005      52354259 +- 1552791      6      good
chromium@500030      52502165 +- 2466097      6      good
chromium@500034      51837351 +- 1685557      6      good
chromium@500035      52206095 +- 1284489      6      good
chromium@500036      76173427 +- 3624168      6      bad       <--
chromium@500037      76618994 +- 3345454      6      bad
chromium@500043      77013034 +- 3403416      6      bad
chromium@500055      76073572 +- 2177074      6      bad
chromium@500105      76440273 +- 3451553      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969005041570562800


For feedback, file a bug with component Speed>Bisection
Owner: sunxd@chromium.org
Issue 763336 has been merged into this issue.

Comment 6 by sunxd@chromium.org, Sep 11 2017

The regression is expected since we prevent mask layers from generating solid color draw quads. We will fix the blurry regression issue and re-enable it. I will keep the bug open till re-enabling.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Sep 12 2017

 Issue 763272  has been merged into this issue.
Labels: -Performance-Sheriff

Comment 9 by sunxd@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)
Now mask tiling is re-enabled and solid color analyzer patch has landed again. Marking it fixed.

Sign in to add a comment