New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763401 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Windows AMD WebGL conformance test failing

Project Member Reported by danakj@chromium.org, Sep 8 2017

Issue description

FWIW the actual ANGLE regression range only has one very innocent CL:

https://chromium.googlesource.com/angle/angle.git/+log/1de29ab..95644f92dd1

No idea why AMD might be failing with hubbe's change or skia.
OK let's intersect these 3 first failed builds:

1) 500373-474
2) 500429-498
3) 500461-491

So the failure will be in 500429-500474

https://chromium.googlesource.com/chromium/src/+log/e7d66efe5dd9396bc97569640704f33202edef6e..d7718847e9938b80e58148d91555c2bb6eff9b14

Components: Blink>WebGL
An example failure:

[6/179] gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_glsl3_shader_with_invalid_characters passed 0.1720s
[1728:2508:0907/212241.022:INFO:CONSOLE(118)] "should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.023:INFO:CONSOLE(118)] "FAIL should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.054:INFO:CONSOLE(118)] "should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.054:INFO:CONSOLE(118)] "FAIL should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.070:INFO:CONSOLE(118)] "should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.070:INFO:CONSOLE(118)] "FAIL should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.089:INFO:CONSOLE(118)] "should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)
[1728:2508:0907/212241.089:INFO:CONSOLE(118)] "FAIL should be green at (0, 0) expected: 0,255,0,255 was 255,0,0,255", source:  (118)

Cc: geoffl...@chromium.org
Owner: hubbe@chromium.org
Status: Assigned (was: Untriaged)
> 1) 500373-474
> 2) 500429-498
> 3) 500461-491
> 
> So the failure will be in 500429-500474

OOPS. Intersect means it's 500461-500474.

https://chromium.googlesource.com/chromium/src/+log/0e7dd5e393d7d838f7ffac633c727dd4e7a036fa..d7718847e9938b80e58148d91555c2bb6eff9b14

hubbe's patch is the only remaining suspect.

Comment 8 by hubbe@chromium.org, Sep 8 2017

Great, so my patch fixes things on intel and break things on AMD. :(
Can we just blacklist Windows?

Components: Internals>GPU
Labels: Hotlist-PixelWrangler

Comment 10 by kbr@chromium.org, Sep 8 2017

What do you mean by blacklisting Windows? If you mean blacklisting a certain feature on certain GPUs, yes, that's done all the time -- but that doesn't sound like what's going on here.

It's not workable to mark these tests as expected failures. That will leave a huge gap in testing.

We need to get to the bottom of these failures and fix them.

If some of the GPU bots seem misconfigured -- for example, if their display color profiles vary -- we can either work with the Labs team to fix this, or pass some command line flag which will force the use of a particular color profile.

Please own this issue and tell us what we can do to help you.

Comment 11 by kbr@chromium.org, Sep 8 2017

Components: -Internals>GPU Internals>GPU>VendorSpecific
Labels: OS-Windows
Sorry, I was making a bad joke about blacklisting Windows.

The problem isn't that the bots are badly configured (I think), the problem is that video APIs on windows are a minefield of bugs which I don't know if I can navigate. I'm going to take another look at the machine I was using yesterday and see if I made a mistake, or if that machine just behaves differently from the bot. I might also try a few alternate ways to patch the problem, but trial-and-error with FYI bots is pretty slow process.


Comment 13 by kbr@chromium.org, Sep 8 2017

You can log onto these machines directly, take them offline briefly and run your own binaries on them. I would strongly advocate that you try this. It's not that bad a process and I personally do it for the really tough bugs that only reproduce on one particular machine. The instructions for logging on to the bots are linked from https://www.chromium.org/developers/testing/gpu-testing#TOC-Running-Locally-Built-Binaries-on-the-GPU-Bots . If the instructions are incorrect in any way please tell me.
 
If you want Geoff or me to beta-test a patch we can do that too. We have a machine that can run Intel/AMD/NVIDIA gpus on Windows 7 and 10.

Comment 15 by hubbe@chromium.org, Sep 13 2017

Status: Fixed (was: Assigned)
The patch that was causing this was reverted.
The new fix has been deployed, without breaking the AMD bots.

Comment 16 by kbr@chromium.org, Sep 13 2017

Fantastic. Thank you Fredrik for persisting with this fix.

Sign in to add a comment