New issue
Advanced search Search tips

Issue 763398 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Mac build fails with verify_order: unordered symbols in Chromium Framework.framework

Project Member Reported by lfg@chromium.org, Sep 8 2017

Issue description

Full error message:

../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium Framework.framework/Versions/A/Chromium Framework:
__ZN7logging11CheckLTImplIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryiEEPNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEERKT_RKT0_PKc
__ZN7logging17MakeCheckOpStringIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryiEEPNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEERKT_RKT0_PKc
__ZN7logging22MakeCheckOpValueStringIZNK3net16HostResolverImpl8ProcTask27RecordPerformanceHistogramsERKN4base9TimeTicksEiiE8CategoryEENSt3__19enable_ifIXaasr4base8internal23SupportsOstreamOperatorIRKT_EE5valuentsr3std11is_functionINS9_14remove_pointerISB_E4typeEEE5valueEvE4typeEPNS9_13basic_ostreamIcNS9_11char_traitsIcEEEESD_

args.gn:

use_goma = true
goma_dir = "..."
is_component_build = false
enable_nacl = false
enable_google_now = false

 
The weird thing is that both the public and private waterfall builders look fine.

Comment 2 by mark@chromium.org, Sep 8 2017

net/dns/host_resolver_impl.cc

931      DCHECK_LT(category, static_cast<int>(RESOLVE_MAX));  // Be sure it was set.

Does it help to cast both sides to int?
Components: Build

Comment 4 by lfg@chromium.org, Sep 8 2017

Cc: -mark@chromium.org
Owner: mark@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks, I can confirm that casting it to int fixes the error.

The issue was introduced in https://chromium.googlesource.com/chromium/src/+/223326c134a0cbe5358bd317b2a51bb2c7a4fe67

Mark, can you submit fix for this?

Comment 5 by rsesek@chromium.org, Sep 26 2017

 Issue 768630  has been merged into this issue.

Comment 6 by mark@chromium.org, Sep 26 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96c3116e28f97b03c4448120c8cb43a878ed173

commit e96c3116e28f97b03c4448120c8cb43a878ed173
Author: Mark Mentovai <mark@chromium.org>
Date: Tue Sep 26 17:40:55 2017

Fix macOS non-component debug build

This broke in 223326c134a0.

Bug:  763398 ,  768630 
Change-Id: Ie5e7eb7a7d3ea01a30b8a262db22931c2ed7d4d9
Reviewed-on: https://chromium-review.googlesource.com/684616
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504416}
[modify] https://crrev.com/e96c3116e28f97b03c4448120c8cb43a878ed173/net/dns/host_resolver_impl.cc

Comment 9 by mark@chromium.org, Sep 26 2017

Status: Fixed (was: Started)

Sign in to add a comment