New issue
Advanced search Search tips

Issue 763396 link

Starred by 1 user
Status: Assigned
Owner:
mahmadi@chromium.org
Cc:
rsorokin@chromium.org
se...@chromium.org
pkl@chromium.org
ma...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

Payment Request address editor labels are not title-cased in iOS

Project Member Reported by mahmadi@chromium.org, Sep 8 2017 
These labels come from the libaddressinput
third_party/libaddressinput/chromium/address_input_strings.grdp

We need <if titlecase> statements for these strings. Similar to:

https://cs.chromium.org/chromium/src/components/payments_strings.grdp?rcl=e996f894d9e0a2a9cf7dfe67a2efda60cc8543df&l=77
address-editor.png
66.6 KB View Download

Comment 1 by rouslan@chromium.org, Sep 8 2017

Owner: mahmadi@chromium.org

Comment 2 by rouslan@chromium.org, Sep 8 2017

Labels: -M-63
Nice to have in M-63, but not required in that milestone. Removing the milestone label.

Comment 3 by pkl@chromium.org, Sep 10

Status: Assigned (was: ExternalDependency)
What's the status on this? Please re-evaluate.

Comment 4 by mahmadi@chromium.org, Sep 10

Labels: M-71

Comment 5 by mahmadi@chromium.org, Sep 10

Cc: pkl@chromium.org
pkl@ third_party/libaddressinput/chromium/address_input_strings.grdp is a generated file from the libaddressinput strings. Making title-case vs sentence-case distinction isn't possible at that level. Do we have examples where common strings get overridden for iOS?

Comment 6 by rouslan@chromium.org, Sep 11

Cc: se...@chromium.org
mahmadi@: We could add title case strings in https://github.com/googlei18n/libaddressinput/blob/master/cpp/res/messages.grdp, which sebsg@ maintains.
►

Sign in to add a comment